Closed (fixed)
Project:
Paragraphs Collection
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
15 Mar 2019 at 13:33 UTC
Updated:
2 Apr 2019 at 13:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sasanikolic commentedHere is the patch with the paragraph preprocess.
Comment #3
sasanikolic commentedComment #4
berdirwe can add it directly in the plugin, where we have all information already.
Comment #5
sasanikolic commentedHere is the improved patch with the moved code to the plugin.
Is there a nicer way to flatten the attributes array? This code supports only one level of data-attributes for now. Do we need to support multiple levels?
Comment #6
sasanikolic commentedSorry, that crazyness is not needed. I realized I was defining the attributes the wrong way in the yml file.
Attributes should be defined like this:
Instead, I had the dash in front of data.
Comment #7
berdirYes, that looks good now, but we should have a test for this, extend one of the existing test styles with some attributes and assert they are added.
Comment #8
sasanikolic commentedI added a small test here.
Comment #9
berdirNice.
Comment #11
berdir