PHP 5.3.x fix for syntax changes Views 3.21

+1

Forced to run older version of PHP on RHEL

I'm getting exactly the same problem on my clients who have older servers.

Looks like line 1010 also

$join->extra = [];

Any [] needs to be set to array() to work with PHP 5.x.

Edit: Just to be clear, this impacts earlier versions of PHP 5. I believe PHP 5.3.x requires array()

Hello,

You have to change [] for array().
I've created a patch.

Patch in #7 works here.

trigger tests

Patch in #7 works great for my sites as well

patch 7 looks good as reported

php lint passes for php 5.3.x

https://www.drupal.org/pift-ci-job/1227497

14:51:07 ----------------   Starting phplint   ----------------
14:51:07 Directory created at /var/lib/drupalci/workspace/jenkins-drupal_d7-126508/ancillary/phplint
14:51:07 SyntaxCheck checking for php syntax errors.
14:51:07 /var/lib/drupalci/workspace/jenkins-drupal_d7-126508/ancillary/phplint/lintable_files.txt
14:51:07 cd /var/www/html && xargs -P 36 -a /var/lib/drupalci/workdir/phplint/lintable_files.txt -I {} php -l '{}'
14:51:07 No syntax errors detected in /var/www/html/sites/all/modules/views/includes/handlers.inc
14:51:07 ---------------- Finished phplint in 0.350 seconds ---------------- 

patch 7 works for the code, but the test code still contains [] syntax instead of array()
this explains why the php lint passes on the module but the tests fail

Same issue for us, how is one supposed to apply the patch? which file would we need to modify?

Any help will be greatly appreciated?

I want to wait on a fully baked update as well. Do we know if they would release that today? Or this may be a few days away?

@awasson Thanks Andrew I shall do the same.

Best

How bad is the security issue for the module update that was released? Does the patch in #7 still mitigate this security issue?

The patch in #7 will resolve the PHP syntax problem we introduced by through the fact we use newer versions of PHP locally. It in no way affects the security problems resolved in 7.x-3.21, so you're free to use the patch with 3.21 and not loose any of the security fixes.

Also, sorry for not catching that.

@DamienMckenna thank you for all that you do!! :-)

Yes, thank you! @DamienMckenna

Another thanks to @DamienMckenna!

Wondering how we mitigate this going forward in the contrib space. I'm also guilty of accidentally using short array syntax locally without thought of very old versions. We wish 5.3 wasn't still deployed, but we need to keep supporting it since it's on the list (for now):
https://www.drupal.org/docs/7/system-requirements/php-requirements#php_r...

Even after it's removed, using short array syntax will break a ton of sites in higher ed, for example, that often lag tremendously in updating their infrastructure.

Reroll with the tests changed to traditional syntax as well.

I've kicked off a PHP 5.3 testbot on patch #25..

Any ETA for the release of the new module update?

Please merge this patch ASAP - badly needed.

Excellent job dromansab, joelpittet

I prefer to wait for the next version because I'm using php 5.3 on D7 and apparently the problem is giving it to everyone

@Massimo25, you should be able to use the patch with confidence until a new version is available. Certainly not having the patch creates a problem for those running PHP 5.3.x, but it's a minor issue in the entire scope of possible issues.

Committed. Thank you to everyone for working on this, I really appreciate it and, again, I'm sorry for letting that syntax change slip past us.

I'd like to encourage people with sites still using PHP 5.3 to: a) upgrade to a newer version of PHP, b) help test the current dev snapshot so we can get a 7.x-3.22 out ASAP with this and a wealth of other fixes.

I’ve been using the dev snapshot on at least of the sites we manage still on PHP 5.3. It has a nice notice fix for exposed filters:)

Patch #25 works thanks you !

I can confirm that current dev fixes the issue on PHP 5.3.3

Thank you!

I can also confirm that patch #25 is working OK on a couple of different servers and sites. Thanks.

Using shared hosting, one is at the mercy of the host for the PHP version. Through this problem I've discovered I could specify 5.6 at the host's control panel (their default was 5.3).

Views now installs fine.

PHP 5.3 hasn't been officially supported by the PHP community in.. four and a half years, asking your hosting provider to upgrade their out-of-date software isn't irrelevant, neither is suggesting you consider a different hosting provider that puts a bit more effort into maintaining their infrastructure.

Red Hat is still supporting php 5.3.x afaik.
however, ya , I always encourage my clients to upgrade to php 7.x but this is not always easy to do as often they have servers hosting multiple applications.

Guys, in the meantime I run the update in case it causes problems retrocedo to the previous version but I suppose everything should be fine

Thanks for this, This solved my issue.
This should be included in the next release

I had the same error as described in: https://www.drupal.org/project/views/issues/3040789 when updating views with drush.

For what it's worth, I am running PHP 5.6.25 on RHEL 6.10 via Software Collections.

I applied patch #25 and no longer see the error.

Tarzadon,
Your vhost is misconfigured if you say you needed this patch for php 5.6.x

This is a php <= 5.3.x bug. Not 5.6

Happy to report that the dev version works for us! Many thanks!

Patch #25 resolved the issue for us.
We are also blocked with version 5.3.3 due RHEL 6

Thanks for the patch

Patch #25 worked for me. We have been hit with this issue several times because we have support contracts with sites that are running PHP 5.3, so I hope that a new version will be released soon.

Can we get a new release with this fix, so that it doesn't keep breaking contrib testing with PHP 5.3?

could anyone tell us when the new release that will work for 5.3 will be please?

@awasson: You missed my point. Contributed module which have a dependency on Views cannot currently be tested against PHP 5.3 because the testbot uses the 3.21 release for testing, not the -dev, and not a patched version.

Because Views is so widely used, and because so many contributed modules depend on Views, PHP 5.3 testing is currently broken for many Drupal 7 modules. That is why a new release is needed as soon as possible.

@awasson: Oh, I guess *I* missed *your* point :-)

I decided to release this one single fix as 7.x-3.22: https://www.drupal.org/project/views/releases/7.x-3.22

Sorry for taking so long.

Sorry, the problem still persists for aggregated views. Had to return to 3.20 on a production site. :(
As the site is running with docker I will upgrade to php7 soon.

@Pepe Roni: Please a) test the current dev snapshot, b) check other issues, this one was just about the syntax problems.

Warning: Illegal offset type in views_many_to_one_helper->ensure_my_table() (Zeile 1023 von /var/www/html/drupal/sites/all/modules/contrib/views/includes/handlers.inc).
and
SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ')AND (field_myfieldname' at line 12
are the errors described in this issue.
At least these errors do not occur in 3.20.

Just checked: the current dev-snapshot has solved this problem :)

@Pepe: Thank you for the update.