Closed (fixed)
Project:
Fragments
Version:
8.x-1.0-beta1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
12 Mar 2019 at 16:11 UTC
Updated:
6 Jan 2020 at 21:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Snehal Brahmbhatt commentedHere's the patch on the same kindly review it.
Comment #3
eelkeblokSeems to be for D7 version.Sorry, not true.Comment #4
eelkeblokIt seems code sniffer is actually judging the @code end @endcode tags as though they are one of the sections that could go a in a docblock. I think this is wrong. These are actually part of the @param array $settings setction; in short, I think this change should not be applied (adding a blank line, although dictacted by the code sniffer warnings, is actually in direct violation with this comment style rule: https://www.drupal.org/docs/develop/standards/api-documentation-and-comm... ("Do not use a blank line between the text that explains the code sample and the code sample itself.").
The other two changes look OK.
Comment #6
eelkeblok