Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Another child of #2886622: Deprecate all EntityManager methods with E_USER_DEPRECATED, this time the various methods on EntityDisplayRepository.
Apparently there is almost nothing left here, most things were already converted, so this takes care of the last view cases and @trigger_error() + deprecation tests.
Comment | File | Size | Author |
---|---|---|---|
#8 | entity-display-repository-3038926-8-interdiff.txt | 4.39 KB | Berdir |
#8 | entity-display-repository-3038926-8.patch | 36.75 KB | Berdir |
Comments
Comment #2
BerdirComment #4
BerdirOoops.
Comment #6
BerdirFixed CommentDefaultFormatter.
Comment #8
BerdirComment #9
jibranDo we need to update some CN?
Comment #10
martin107 CreditAttribution: martin107 as a volunteer commentedI have had a slow visual scan of the patch, sometimes it is useful to have a second pair of eyes look things over
a) All changes related to the issue.
b) All changes appear to be implemented correctly.
c) No additional coding standard errors are introduced.
d) As far as I can see the DeprecatedServicePropertyTrait is added where pertinent.
e) The text in the @trigger_error and @expectedDeprecation follow established patterns and seem helpful.
so +1 from me.
Comment #11
andypostChecked it as well, no issues found
@jibran that's just a proper deprecation (replace, add throw error & tests) so no CRs needs update because all this methods already deprecated before 8.0 via https://www.drupal.org/node/2549139
Comment #12
catchCommitted 29e5277 and pushed to 8.8.x. Thanks!