Another child of #2886622: Deprecate all EntityManager methods with E_USER_DEPRECATED, this time the various methods on EntityDisplayRepository.

Apparently there is almost nothing left here, most things were already converted, so this takes care of the last view cases and @trigger_error() + deprecation tests.

CommentFileSizeAuthor
#8 entity-display-repository-3038926-8-interdiff.txt4.39 KBberdir
#8 entity-display-repository-3038926-8.patch36.75 KBberdir
#6 entity-display-repository-3038926-6-interdiff.txt3.83 KBberdir
#6 entity-display-repository-3038926-6.patch34.71 KBberdir
#4 entity-display-repository-3038926-4-interdiff.txt4.28 KBberdir
#4 entity-display-repository-3038926-4.patch33.96 KBberdir
#2 entity-display-repository-3038926-2.patch31.94 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
Parent issue: #3035953: Add @trigger_error() to deprecated EntityManager->EntityFieldManager methods » #2886622: Deprecate all EntityManager methods with E_USER_DEPRECATED
StatusFileSize
new entity-display-repository-3038926-2.patch31.94 KB

Status: Needs review » Needs work

The last submitted patch, 2: entity-display-repository-3038926-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new entity-display-repository-3038926-4.patch33.96 KB
new entity-display-repository-3038926-4-interdiff.txt4.28 KB

Ooops.

Status: Needs review » Needs work

The last submitted patch, 4: entity-display-repository-3038926-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new entity-display-repository-3038926-6.patch34.71 KB
new entity-display-repository-3038926-6-interdiff.txt3.83 KB

Fixed CommentDefaultFormatter.

Status: Needs review » Needs work

The last submitted patch, 6: entity-display-repository-3038926-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new entity-display-repository-3038926-8.patch36.75 KB
new entity-display-repository-3038926-8-interdiff.txt4.39 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Do we need to update some CN?

martin107’s picture

martin107 commented

I have had a slow visual scan of the patch, sometimes it is useful to have a second pair of eyes look things over

a) All changes related to the issue.
b) All changes appear to be implemented correctly.
c) No additional coding standard errors are introduced.
d) As far as I can see the DeprecatedServicePropertyTrait is added where pertinent.
e) The text in the @trigger_error and @expectedDeprecation follow established patterns and seem helpful.

so +1 from me.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Checked it as well, no issues found

@jibran that's just a proper deprecation (replace, add throw error & tests) so no CRs needs update because all this methods already deprecated before 8.0 via https://www.drupal.org/node/2549139

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 29e5277 and pushed to 8.8.x. Thanks!

  • catch committed 29e5277 on 8.8.x 
    Issue #3038926 by Berdir: Add @trigger_error() to deprecated...

  • catch committed e10d7ab on 8.7.x 
    Issue #3038926 by Berdir: Add @trigger_error() to deprecated...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.