Over in #2932083: Views Table style plugin breaks dynamic cache , we made Views table displays cacheable in the dynamic cache by switching max-age: 0 to max-age: -1. However, the default install YAMLs were not updated with this change. The easiest way to see which Views are affected is to a) install a fresh 8.6.x. core with the config_update module, b) take a look at the reported views.* differences at Administration > Configuration > Configuration synchronization > Update reports > Everything.

CommentFileSizeAuthor
#2 update-views-max-age-3038408-2.patch3.98 KBmorbus iff

Comments

Morbus Iff created an issue. See original summary.

morbus iff’s picture

morbus iff
they/them
commented
Issue summary: View changes
StatusFileSize
new update-views-max-age-3038408-2.patch3.98 KB

This patch appears to apply to both 8.6.x and 8.7.x. Note that in 8.6.x., there's a similar max-age: 0 vs. -1 tweak necessary for views.view.media-library.yml, but this appears to have been automatically corrected with the 8.7.x changes committed in #2981044: Unify the grid/table views of the media library.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#2932083: Views Table style plugin breaks dynamic cache
morbus iff’s picture

morbus iff
they/them
commented
Status: Active » Needs review

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Needs review » Needs work 
+++ b/core/modules/media/config/optional/views.view.media.yml
@@ -1,6 +1,8 @@
+  config:
+    - image.style.thumbnail

Unrelated change, might need a follow up, but lets not change it here.

And if I look for max-age: 0 I find a lot more instances, for example:
/core/modules/node/config/optional/views.view.content.yml
/core/modules/comment/config/optional/views.view.comment.yml

But you are correct that these don't need updates here because the settings seems to originate somewhere else then the display setting and these are still accurate.

morbus iff’s picture

morbus iff
they/them
commented

Unrelated change, might need a follow up, but lets not change it here.

Yeah, these were just straight exports from the config system.

You want me to export the configuration and then modify it?

Or should I retweak the issue title to be more inclusive?
("Re-export table style views affected by the max-age dynamic cache change"?)

And if I look for max-age: 0 I find a lot more instances, for example:

Indeed! But the only configs that were different (after a fresh standard profile install), in relation to max-age, were those specifically using display "style: table". You nailed it on the head that the changes were specifically related to #2932083: Views Table style plugin breaks dynamic cache .

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Closed (duplicate)
Related issues: +#3059545: Improve \Drupal\KernelTests\Config\DefaultConfigTest to install all optional configuration

Nice find @Morbus Iff - I found this a different way via the testing system - I'm going to mark this issue as a duplicate of #3059545: Improve \Drupal\KernelTests\Config\DefaultConfigTest to install all optional configuration even though this one is older because it has a slightly increased scope and has test coverage. Will give contributors here credit over there.