Problem/Motivation

Each layout builder section has a "configure section" link.
They all have the same name, and there is no way to distinguish between them with assistive tech.

Basically the same problem as #3013770: Distinguish between the repeated text of buttons in Layout Builder UI and #3015004: Distinguish between the repeated text of remove-section buttons in Layout Builder UI.

Proposed resolution

Give all of the "configure section" buttons a unique accessible name... e.g. "Configure section 2".
Put the number in a visually-hidden span.

Remaining tasks

Patch

User interface changes

No visible design changes intended.
Improve accessible names, primarily to help screen reader users.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 3037129-section-5.patch2.82 KBtim.plunkett

Comments

andrewmacpherson created an issue. See original summary.

tim.plunkett’s picture

Issue tags: -accessibility (duplicate tag) +Accessibility, +Blocks-Layouts

Fixing tag

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

xjm’s picture

Assigned: Unassigned » tim.plunkett
Priority: Normal » Major
Issue tags: +Layout Builder stable blocker

@andrewmacpherson identified this as an accessibility gate must-have, so tagging as a stable blocker. Tim says this was a definite oversight and is working on this as we speak.

tim.plunkett’s picture

Status: Active » Needs review
StatusFileSize
new2.82 KB

I don't know how we missed this when we did #3015004: Distinguish between the repeated text of remove-section buttons in Layout Builder UI, but glad it was caught!

phenaproxima’s picture

Status: Needs review » Reviewed & tested by the community

I see absolutely nothing wrong with this patch. The fix is simple and clean, and the tests prove it works. So, let's go. RTBC once green.

  • xjm committed f3bafe5 on 8.8.x
    Issue #3037129 by tim.plunkett, andrewmacpherson, phenaproxima: Use...

  • xjm committed df35a22 on 8.7.x
    Issue #3037129 by tim.plunkett, andrewmacpherson, phenaproxima: Use...
xjm’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.8.x and cherry-picked to 8.7.x as a clear accessibility bug (and also it's just a string change, which is allowed any time up until RC).

Thanks for the quick turnaround on this!

xjm’s picture

Fixing credit; silly xposts with System Message.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.