Problem/Motivation

Currently the module is designed with google/apiclient": "1.1.*. However, the current version of the google/apiclient is 2.x, see https://developers.google.com/gmail/api/quickstart/php

Proposed resolution

Update the Google API Communicator to work with google/apiclient:2.x

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

To be determined.

Data model changes

To be determined.

Release notes snippet

Updated the Google API Communicator to work with google/apiclient:2.x

CommentFileSizeAuthor
#8 google_api_communicator-update_google_apiclient-3036067-8.patch16.95 KBidebr
#8 interdiff-4-8.txt420 bytesidebr
#4 interdiff-3-4.txt9.8 KBidebr
#4 google_api_communicator-update_google_apiclient-3036067-4.patch16.53 KBidebr
#3 google_api_communicator-update_google_apiclient-3036067-3.patch6.83 KBidebr
#3 interdiff-2-3.txt1.31 KBidebr
#2 google_api_communicator-update_google_apiclient-3036067-2.patch6.77 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new google_api_communicator-update_google_apiclient-3036067-2.patch6.77 KB

Attached patch implements the following changes:

  1. Since Composer Manager will only include composer.json files for enables modules, the Google API Communicator module has a circular dependency. The hook_requirements() implementation is now called on runtime instead.
  2. Replaced !placeholder arguments with @placeholder arguments, see https://www.drupal.org/docs/7/api/localization-api/dynamic-or-static-lin...
  3. Updated hook_libraries_info() with the version 2 autoloader file.
  4. Updated composer.json to the version recommendation from https://developers.google.com/gmail/api/quickstart/php and applied composer coding standards.
  5. Updated the admin form so the token is saved correctly as an array instead of a string.
idebr’s picture

idebr commented
StatusFileSize
new interdiff-2-3.txt1.31 KB
new google_api_communicator-update_google_apiclient-3036067-3.patch6.83 KB

The google_api_communicator_accesstoken can be an empty string after unauthenticating, so the code needs to check for a value appropriately.

idebr’s picture

idebr commented
StatusFileSize
new google_api_communicator-update_google_apiclient-3036067-4.patch16.53 KB
new interdiff-3-4.txt9.8 KB

Attached patch extends google/apiclient:2.x support for the google_api_communicator_users submodule. For users, the access token is encrypted using the encrypt module.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented

Hi Ide,

Thanks for your interest in this module. I no longer have a need for it, as such I have not spend much time on it lately. I will try to find some time to review your patch in the upcoming week. Would you have an interest in becoming a maintainer? You are probably using this module more than me now.

idebr’s picture

idebr commented

Hi Robin,

I'm currently implementing the module for a client of ours. I'd be happy to patch out any necessary changes as a maintainer. Thanks for your work on this module, it has been a real time saver :)

neograph734’s picture

neograph734
he/him
Location Netherlands
commented

You should have permissions now. Use them as you like :)

idebr’s picture

idebr commented
StatusFileSize
new interdiff-4-8.txt420 bytes
new google_api_communicator-update_google_apiclient-3036067-8.patch16.95 KB

Added a dependency on the encrypt module in the info file.

  • 0297828 committed on 7.x-1.x 
    Issue #3036067 by idebr: Update google/apiclient 1.1.x -> 2.x
idebr’s picture

idebr commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.