This is related to the toolbar not properly setting the inline style on the body element and then elements being hidden behind the admin toolbar. This is because the selector is not returning an element--for whatever reason, whether it's some conflict with other modules or what--and then calculating the height of the null element returns 0, totaling to a 40px height (when it should be 79px). Instead of expecting all other modules to not step on this module's toes, we can just use a simpler selector for retrieving the height of the admin toolbar.

I've seen this issue come up a few times and it seems like it's always another modules problem. But after looking at the selector for the JS, it seems like it is an unnecessarily complicated selector. We can simply select the '#toolbar-bar' element and find the height from that element. The expectation being that other modules do not reuse the same selector (which is semantically incorrect anyways since they're duplicating HTML IDs at that point).

CommentFileSizeAuthor
#2 3035946-2.patch761 bytescchoe1

Comments

cchoe1 created an issue. See original summary.

cchoe1’s picture

StatusFileSize
new761 bytes

Patch attached below--I simply remove the .find() method call.

cchoe1’s picture

Issue summary: View changes
dydave’s picture

Status: Active » Closed (outdated)

Thanks everyone for the efforts and work on this issue! 🙏

More than 7 years of inactivity on this issue for the Drupal 6 version of the module which is not supported anymore.

Therefore, closing as Outdated, for now.

Feel free to let us know if you have any questions or concerns on any aspects of this issue or the project in general, we would surely be glad to help. 😊
Thanks in advance!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.