While the making of #2482549: Ignore node_module folder in core to use Drupal with npm/grunt/nodejs, a wrong permission has been committed on the file default.settings.php by mistake.
This patch will restore the original permission.

CommentFileSizeAuthor
#2 3035772.patch117 bytesPol
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pol created an issue. See original summary.

Pol’s picture

Status: Active » Needs review
FileSize
117 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 3035772.patch, failed testing. View results

Pol credited xlin.

Pol’s picture

Adding credits to @xlin.

alexpott’s picture

@Pol I wonder if the D7 maintainers should fork https://github.com/alexpott/d8githooks and use a pre commit hook to check this. It's hard to pick up.

Pol’s picture

Status: Needs work » Active

Very good idea, going to see how to use it for D7.

Thanks!

  • Pol committed bf635f9 on 7.x
    Issue #3035772 by Pol: [Regression] Fix default.settings.php permission
    
Pol’s picture

Status: Active » Fixed

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xlin’s picture

@pol Same issue since 7.64, default.settings.php permission is incorrect again.

Pol’s picture

Hi,

Could you point to the commit where it has been re-introduced ?

Thx

greggles’s picture

Status: Closed (fixed) » Active

Reopening to track the work.

tobiasb’s picture

Project: Drupal core » Drupal.org infrastructure
Version: 7.x-dev »
Component: base system » Packaging

In git all is fine only the download contains a default.settings.php with an execute bit.

drumm’s picture

Project: Drupal.org infrastructure » Drupal core
Version: » 7.x-dev
Component: Packaging » base system
Status: Active » Fixed

The recent security releases 7.65, 7.66, and 7.67 do not include other fixes. They only contain the security fix to make quick upgrades more straightforward. They are branched from the previous release, then merged back into dev.

The last non-security release of 7.x was 7.64, which predates this fix. So it has not made it into a tagged release yet. The dev release looks good.

$ git log --graph --decorate --oneline --date=short 7.x
* 15dec4d974 (HEAD -> 7.x, origin/7.x) Issue #3051370 by Pol, markcarver, Fabianx: Create "scripts" element to align rendering workflow to how "styles" are handled
* fd9e16e34b Back to dev.
*   accbd000d6 Merged 7.67.
|\
| * 09a33aa82a (tag: 7.67) Drupal 7.67
| * ff05c001c9 SA-CORE-2019-007 by Blaklis, oliver.hader, alexpott, mlhess, tim.plunkett, dsnopek, xjm
* | 77c94ea5eb Revert "Issue #3051370 by Pol, Fabianx: Create "scripts" element to align rendering workflow to how "styles" are handled"
* | 5f67268ed9 Issue #3051370 by Pol, Fabianx: Create "scripts" element to align rendering workflow to how "styles" are handled
* | 23ae731d0f Issue #2814031 by Liam Morland: In drupal_http_request(), allow passing data as array
* | 902980e2f6 Issue #1861604 by hefox, joseph.olstad, Sivaji, mgifford, webchick: Skip module_invoke/module_hook in calling hook_watchdog (excessive function_exist)
* | 117ef34685 Issue #2666908 by iamEAP, cilefen: HTTP status 200 returned for ”Additional uncaught exception thrown while handling exception”
* | 85be7c52bb Issue #1892654 by Pol, willvincent, Fabianx: D7 Backport: theme_table() should take an optional footer variable and produce <tfoot>
* | b71e4eb378 Issue #3009351 by Pol, mfb, BrianLP: [PHP ≥ 7.2] "session_id(): Cannot change session id"
* | c8a2662355 Issue #2684337 by geoffray, Pol, jweowu, Fabianx: Warning: uasort() expects parameter 1 to be array, null given in node_view_multiple()
* | 24532b16cf Back to dev.
* |   39e2971f5d Merged 7.66.
|\ \
| |/
| * 9735baff3a (tag: 7.66) Drupal 7.66
| * d2f26902ef SA-CORE-2019-006 by effulgentsia, lauriii, larowlan, xjm, greggles, drumm, dtv_rb, samuel.mortenson
* | 87f903818c Back to dev.
* |   45082e8517 Merged 7.65.
|\ \
| |/
| * c2cae51e5c (tag: 7.65) Drupal 7.65
| * 87942385ae SA-CORE-2019-004 by alexpott, larowlan, greggles, drumm, mlhess, David_Rothstein, pwolanin
* | bf635f9f04 Issue #3035772 by Pol: [Regression] Fix default.settings.php permission
* | d3353e9916 Back to dev
|/
* 868f206924 (tag: 7.64) Release 7.64
…

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.