I've been noticing this on Drupal 8 status pages lately:

Drupal 8 no longer uses the $settings['install_profile'] value in settings.php and it can be removed.

Seems to be coming from the change record The install profile has moved from settings.php to the core.extension configuration object.

CommentFileSizeAuthor
#2 provision-stop_setting_installation_profile_in_settings_php-3035707-2.patch1.33 KBcolan

Comments

colan created an issue. See original summary.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new provision-stop_setting_installation_profile_in_settings_php-3035707-2.patch1.33 KB

This will prevent it from being set, but do we also need a DB update hook to set it in the configuration? There's a note about this in the change record, but I'm not sure if it applies.

Also, I removed some related variables that appear to be unused. They're not mentioned anywhere in the original referenced issue.

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented
Status: Needs review » Reviewed & tested by the community

Reading the changelog, it seems that a `hook_update()` would only be required for an already-installed site. Under normal operation, the `core.extension` config to track install profile would get created when the site is installed, as I understand it. As such, this patch seems sufficient to me.

That said, I haven't actually tested this patch, but it's pretty straightforward, so assuming @colan has proved it works, I think we can commit it :)

  • colan committed 0bbae72 on 7.x-3.x 
    Issue #3035707 by colan: Stopped setting the installation profile in...
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks for review and feedback. As it works fine with testing, and doesn't appear to break anything, I've committed it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.