Problem/Motivation

There is a good amount of shared code between the two, and contrib will need a lot of the same.

Proposed resolution

Provide a trait or base class that can be used.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3035189

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

Status: Active » Postponed

Postponing for now as it's still new code and it would be unfortunate to refactor too early.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

tim.plunkett’s picture

Assigned: Unassigned » tim.plunkett

Theoretically we could do this now, but I'd like to let it sit for a bit still.
Assigning to myself so I don't lose it

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

tim.plunkett’s picture

Assigned: tim.plunkett » Unassigned
Status: Postponed » Active

Assigning to myself so I don't lose it

lol, whoops

DanielVeza made their first commit to this issue’s fork.

danielveza’s picture

Status: Active » Needs review

Opened a MR that:

  1. Adds a new trait call LayoutBuilderEntityFormTrait
  2. Moves all the shared functionality from DefaultsEntityForm & OverridesEntityForm into the trait
danielveza’s picture

Pushed a new commit that addresses the MR feedback. Ready for review again :)

smustgrave’s picture

Status: Needs review » Needs work

Left 2 small suggestions and 1 question.

smustgrave’s picture

Issue tags: +Needs change record

Tagging also for change record as mentioned think this trait will be useful for others.

danielveza’s picture

Status: Needs work » Needs review
Issue tags: -Needs change record

MR feedback addressed, CR created https://www.drupal.org/node/3420954

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Feedback appears to be addressed thanks!

  • catch committed af993a63 on 10.3.x
    Issue #3035189 by DanielVeza, tim.plunkett, smustgrave: Abstract the...

  • catch committed 85c3a3c2 on 11.x
    Issue #3035189 by DanielVeza, tim.plunkett, smustgrave: Abstract the...
catch’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.