Problem/Motivation
There is a good amount of shared code between the two, and contrib will need a lot of the same.
Proposed resolution
Provide a trait or base class that can be used.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3035189
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3035189-abstract-the-shared
changes, plain diff MR !6462
Comments
Comment #2
tim.plunkettPostponing for now as it's still new code and it would be unfortunate to refactor too early.
Comment #4
tim.plunkettTheoretically we could do this now, but I'd like to let it sit for a bit still.
Assigning to myself so I don't lose it
Comment #13
tim.plunkettlol, whoops
Comment #16
danielvezaOpened a MR that:
LayoutBuilderEntityFormTraitDefaultsEntityForm&OverridesEntityForminto the traitComment #17
danielvezaPushed a new commit that addresses the MR feedback. Ready for review again :)
Comment #18
smustgrave commentedLeft 2 small suggestions and 1 question.
Comment #19
smustgrave commentedTagging also for change record as mentioned think this trait will be useful for others.
Comment #20
danielvezaMR feedback addressed, CR created https://www.drupal.org/node/3420954
Comment #21
smustgrave commentedFeedback appears to be addressed thanks!
Comment #24
catchCommitted/pushed to 11.x and cherry-picked to 10.3.x, thanks!