Closed (fixed)
Project:
Drupal core
Version:
10.3.x-dev
Component:
layout_builder.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
22 Feb 2019 at 22:53 UTC
Updated:
18 Mar 2024 at 11:19 UTC
Jump to comment: Most recent
Comments
Comment #2
tim.plunkettPostponing for now as it's still new code and it would be unfortunate to refactor too early.
Comment #4
tim.plunkettTheoretically we could do this now, but I'd like to let it sit for a bit still.
Assigning to myself so I don't lose it
Comment #13
tim.plunkettlol, whoops
Comment #16
danielvezaOpened a MR that:
LayoutBuilderEntityFormTraitDefaultsEntityForm&OverridesEntityForminto the traitComment #17
danielvezaPushed a new commit that addresses the MR feedback. Ready for review again :)
Comment #18
smustgrave commentedLeft 2 small suggestions and 1 question.
Comment #19
smustgrave commentedTagging also for change record as mentioned think this trait will be useful for others.
Comment #20
danielvezaMR feedback addressed, CR created https://www.drupal.org/node/3420954
Comment #21
smustgrave commentedFeedback appears to be addressed thanks!
Comment #24
catchCommitted/pushed to 11.x and cherry-picked to 10.3.x, thanks!