Problem/Motivation
Follow-up to #2937639: Umami Theme - a11y context is needed for read more links. See comments #9-10 and #22-23 there.
Each card display for nodes has 2 links to the standalone node page:
- The node title
- The "view bundle" link (recipe, or article)
These links are unnecessary duplication, and undesirable effort for keyboard user's tabbing.
Proposed resolution
From comment #10 at #2937639-10: Umami Theme - a11y context is needed for read more links:
Remove link around titles.
Keep the View bundle link
Remaining tasks
Patch for the node card templates (2 variant displays)
User interface changes
No visual design changes.
Eliminates some duplicate links, greatly reduces effort for keyboard users when tabbing.
Comments
Comment #2
goska_m commentedComment #3
goska_m commentedI'm going to be working on this issue today
Comment #4
goska_m commentedComment #6
andrewmacpherson commentedThis doesn't need to do so much. We addressed the WCAG link purpose for the "view bundle" in the previous issue.
Now that #2937639: Umami Theme - a11y context is needed for read more links is fixed, the remaining thing is to remove the links from the node title in these card templates.
Comment #7
shaalHaving the title as a link is what most user would expect.
I created a patch that using
tabindex="-1"on the Title, so keyboard navigation would skip this link.(I think we should also link the image itself to the article/recipe, and skip it the same way as the above solution, but perhaps that should become a separate issue?)
Comment #8
andrewmacpherson commentedThis was supposed to be a simple follow-up for something that was already agreed by the OOTB maintainers, in #2937639-10: Umami Theme - a11y context is needed for read more links.
The problem with this tabindex approach is it creates inequality, by treating users differently. Putting users into separate silos isn't good for accessibility or inclusion.
.
Now imagine three such users are having a conference call, and the mouse user says "click the title"....
This was already removed in a previous issue.
Comment #9
tim.plunkettFixing tags
Comment #10
shaalFinally... the simple solution @andrewmacpherson asked for.
Comment #11
pawandubey commentedPatch#10 reviewed, tested and working fine as per the attached screenshot where the link is removed from the title.
We can move this to RTBC
Comment #12
shaal@pawandubey thank you for reviewing this.
If you tested it and it's good, can you please mark it as RTBC?
Comment #13
pawandubey commentedComment #15
shaalTriggering testbot again as it looks like it was having a rough time earlier...
Comment #16
shaalComment #18
pawandubey commented@shaal
I just verified and found the file is changed in the latest version. So, please re-roll the patch.
Comment #19
Mixologicthat last rtbc->needs work was a bug in drupalci. If the patch doesnt apply, rtbc retesting will catch it.
Comment #20
gábor hojtsyComment #21
gábor hojtsyCommitted 390ffde and pushed to 8.8.x and 8.7.x. Thanks!