This is a followup to #2447727: Add base class for migrating reference fields. The work there to make the base class expanded to included improvements to field migrations that were considered out of scope. Those out of scope changes are moved here.

The change adds two methods MigrateFieldInterface, transformFieldStorageSettings and transformFieldInstanceSettings.

Issue fork drupal-3033522

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quietone created an issue. See original summary.

quietone’s picture

Status: Active » Needs review
StatusFileSize
new66.54 KB

This is the work from the other issue without the ReferenceBase Class and with some changes to NodeReference an UserRefernce. Probably have test failures, but it is a start.

Status: Needs review » Needs work

The last submitted patch, 2: 3033522-2.patch, failed testing. View results

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

quietone’s picture

Status: Needs work » Needs review
StatusFileSize
new39.28 KB
new44.67 KB

Rerolling. I found this reroll a bit difficult and proceeded to fix some tests as well to make at least some of the changes are working.

Status: Needs review » Needs work

The last submitted patch, 8: 3033522-8.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
StatusFileSize
new1.94 KB
new45.81 KB

Fixes for two of the tests.

Status: Needs review » Needs work

The last submitted patch, 10: 3033522-10.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
StatusFileSize
new1.94 KB
new50.98 KB

Adding some tests

quietone’s picture

StatusFileSize
new687 bytes
new50.98 KB

Forgot to run commit-code-check, again.

Status: Needs review » Needs work

The last submitted patch, 13: 3033522-13.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
StatusFileSize
new3.58 KB
new54.65 KB

Restore dependency of field migration on d6_user_role. Use transformFieldStorageSettings for more fields.

Status: Needs review » Needs work

The last submitted patch, 15: 3033522-15.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
StatusFileSize
new17.92 KB
new71.6 KB

Expanded to include Drupal 7 source.

quietone’s picture

StatusFileSize
new16.66 KB
new71.6 KB

Try again.

quietone’s picture

StatusFileSize
new71.6 KB

Status: Needs review » Needs work

The last submitted patch, 19: 3033522-18.patch, failed testing. View results

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

JeroenT made their first commit to this issue’s fork.

jeroent’s picture

Status: Needs work » Needs review

I made a reroll of the patch in #19 and fixed the failing tests.

mikelutz’s picture

Status: Needs review » Needs work
Issue tags: +Portland2022, +Needs issue summary update

There's a lot going on here, and not a lot of documentation in the issue as to what we are trying to do. In general, I like it, looks like we can move more field specific stuff into the field plugins rather than a lot of one off case handling at the process level, but I'm a bit lost as to where to start.

The change adds two methods MigrateFieldInterface, transformFieldStorageSettings and transformFieldInstanceSettings.

This alone scares me off, lol. Can we get the issue summary updated with a bit more information, so I can better understand exactly what I'm reviewing?

NW for the issue sumary update.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.