Here's a preliminary patch. I KNOW this will break many Unit tests and some Kernel tests, just posting the patch here as a way to identify those problem tests.

This patch doesn't include changes to the RulesLogger.

CommentFileSizeAuthor
#7 3033478-kernel-tests.patch4.49 KBtr
#4 3033478-4-messenger-service.patch35.67 KBtr
#3 3033478-3-messenger-service.patch34.93 KBtr
#2 3033478-messenger-service.patch18.86 KBtr
messenger.patch7.25 KBtr

Comments

TR created an issue. See original summary.

tr’s picture

tr commented
StatusFileSize
new 3033478-messenger-service.patch18.86 KB

Let's see if this fixes some of the fails...

tr’s picture

tr commented
StatusFileSize
new 3033478-3-messenger-service.patch34.93 KB

Now fix the RulesLogger too, plus the logger tests.

tr’s picture

tr commented
StatusFileSize
new 3033478-4-messenger-service.patch35.67 KB

And now with one instance of drupal_get_messages() changed to the messenger service.

  • TR committed ee783f0 on 8.x-3.x 
    Issue #3033478 by TR: Replace drupal_set_message with messenger service
tr’s picture

tr commented
Status: Active » Fixed

Committed.

tr’s picture

tr commented
Status: Fixed » Needs review
StatusFileSize
new 3033478-kernel-tests.patch4.49 KB

Follow-up patch - I forgot to add the changes to the Kernel tests...

  • TR committed 84a5952 on 8.x-3.x 
    Follow-up to issue #3033478 by TR: Replace drupal_set_message with...
tr’s picture

tr commented
Status: Needs review » Fixed

Committed follow-up.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.