The listing of themes in the Dropdown seems to be sorted in a bit of a random way. Ideally the themes would be sorted alphabetically.

CommentFileSizeAuthor
#11 After adding patch.png75.12 KBdivya.sejekan
#11 BeforeAddingPatch.png81.1 KBdivya.sejekan
#9 Alphabetical-listing-by-label-3033403-9.patch1.13 KBrishabhthakur
#9 interdiff_3-9.txt1.07 KBrishabhthakur
#3 AlphabeticalListing-3033403-3.patch661 bytesKavya_akhil

Comments

jwilson3 created an issue. See original summary.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Priority: Normal » Minor
Kavya_akhil’s picture

Kavya_akhil commented
StatusFileSize
new AlphabeticalListing-3033403-3.patch661 bytes

@jwilson3, Here is the patch to sort the drop down in alphabetical order

Kavya_akhil’s picture

Kavya_akhil commented
Status: Active » Needs review
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs review » Reviewed & tested by the community
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

Hi, I think it would be much clearer for end users to have the list sorted by theme name instead of the theme key (machine name) using a natural language sort.

Need to build a multi-dimensional associative array of theme_name => theme_machine_name and then sort it with either array_multisort($array, SORT_NATURAL); or natsort(). I'm not sure how natural sorts work with associative arrays so this needs some experimentation.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Reviewed & tested by the community » Needs work
rishabhthakur’s picture

rishabhthakur commented
Assigned: Unassigned » rishabhthakur
rishabhthakur’s picture

rishabhthakur commented
Assigned: rishabhthakur » Unassigned
Status: Needs work » Needs review
StatusFileSize
new interdiff_3-9.txt1.07 KB
new Alphabetical-listing-by-label-3033403-9.patch1.13 KB

Hi @jwilson3 , Modify #3 patch for sorting theme array with labels not by theme_machine_name,
but as per code base of theme array are object and nasort, array_multisort will work on identical key, value array type.
so I have modify theme options array & then apply sorting by label, theme_name.

Please review & confirm

divya.sejekan’s picture

divya.sejekan commented
Assigned: Unassigned » divya.sejekan
divya.sejekan’s picture

divya.sejekan commented
Assigned: divya.sejekan » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new BeforeAddingPatch.png81.1 KB
new After adding patch.png75.12 KB

Observation :
Theme list is arranged in alphabetical order.

Testing steps:
1. Install module , apply the patch
Applied patch " Alphabetical-listing-by-label-3033403-9.patch "
2. Create a new content type , with theme field
3. While creating node , check the theme field for Alphabetical ordered theme list.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

@rishabhthakur good job — your change is exactly what I was expecting to see. Thanks. RTBC++

  • jwilson3 committed cdd5c72 on 8.x-1.x 
    Issue #3033403 by rishabhthakur, Kavya_akhil, divya.sejekan, jwilson3:...
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.