In the last commit of the 8.x-1.4 release strict comparison with an integer 0 is added to line 33 of RendererBase.php. This causes the functionality to fail since the value coming out of the rowPlugin->options array (e.g. 'end') are strings. Comparing string 0 to integer 0 will always return FALSE.

I suggest to either revert the strict comparison or compare to a string 0. Patch will follow.

CommentFileSizeAuthor
#4 fix-strict-comparison-3031617-4.patch844 bytesmarty2081
#2 fix-strict-comparison-3031617-1.patch2.28 KBmarty2081

Comments

Marty2081 created an issue. See original summary.

marty2081’s picture

marty2081 commented
StatusFileSize
new fix-strict-comparison-3031617-1.patch2.28 KB

And here is a patch to compare with a string '0'.

marty2081’s picture

marty2081 commented
Status: Active » Needs review
marty2081’s picture

marty2081 commented
StatusFileSize
new fix-strict-comparison-3031617-4.patch844 bytes

Oops. Wrong patch that tried to fix other stuff I noticed. Here is the correct patch.

  • Pol committed 1770c85 on 8.x-1.x authored by Marty2081 
    Issue #3031617 by Marty2081: Strict comparison introduced in 8.x-1.4...
marty2081’s picture

marty2081 commented
Status: Needs review » Fixed

I see you committed the patch, so the status is fixed now ;)

pol’s picture

pol
the/that
Location Brussels
commented
Status: Fixed » Needs review

Thanks !!

marty2081’s picture

marty2081 commented
Status: Needs review » Fixed

And back to fixed...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.