Search placeholder text is longer than the search box

@shaal what browser is this on? Just tested on Chrome 71.0.3578.98 and FireFox 63.0.3 on MacOS 10.13.6 and the placeholder text fits comfortably without the patch.

I'm having the same issue where the placeholder text doesn't fit in the search field. Browser - Firefox 65.0

+++ b/core/profiles/demo_umami/themes/umami/css/components/blocks/search/search.css
@@ -90,8 +90,8 @@
+  .search-block-form .form-search {

What's the reason behind being more specific?

I've just updated to the latest FF and still can't recreate

Now that's a strange one.

I'm getting the same issue on Chrome too (72.0.3626.81). Screen res is - 2560x1440. OS - Ubuntu 16.04

@shaal interesting. I only tested with 8.7.x.

I think the problem is of the style that does not fit the screen correctly.

I'm running Ubuntu 18.04.02 LTS, Resolution 1366x768. FIrefox 65.0.1.

Reviewed the patch on #2 and can confirm that the width of the field does increase as intended but this causes a responsive layout error with the user menu right at the breakpoint where the field first appears - see screenshot.

I am also unable to replicate the original issue, but with this patch only affecting this one field, I don't think this has any knock-on effects to be concerned about once the responsive issue is resolved.

As per @bash247's in #5, I'm not sure for the additional specificity but this patch doesn't seem to affect the search results page field which would be the likely issue of this being more specific.

Looking good. I tested this in Safari and Chrome and this adds the extra horizontal width to the field, ensures the placeholder text is visible and has resolved the issue I raised in #13 where the user menu is pushed beneath the field at the breakpoint size.

Also tested logged in to ensure the additional menu items do not cause an issue. Looks good there as well.

Marking RTBC :)

The patch in comment #15 no longer applies on 8.8.x so I'm moving this back to Needs Work.

This also applies to Spanish. so we should check that the search box is long enough in Spanish. I think it is already.

Confirming that patch works . The placeholder in english is fully visible in the search bar

I checked it in Spanish with @gaddamsr as well.

Removed Needs re-roll tag as we have a reroll. Thank you, @shaal!

Back to RTBC based on @kjay's review in #17 and reviewing @shaal's quick re-roll and @gaddamsr's review.

Edit: gaddasmsr did a re-roll as well at MidCamp 2019, but was not able to post it before shaal. So I asked him to review the re-rolled patch based on his own work.

I don't think this can ever be fully attained, but better default looks in most browsers tested is still better than known issues we could easily fix.

Assigning credits.

Thanks all, committed!