There is some coding standard issue for this module.

Please refer to the screenshot attached file: coding_standard_issue.png

Thanks.

CommentFileSizeAuthor
#4 anonymou_login_codding_standarts-3030001-4.patch2.18 KBandrew_tspkh
#2 coding_standards-3030001-2.patch1.43 KBpatelmayank7552
coding_standard_issue.png178.27 KBpatelmayank7552

Comments

patelmayank7552 created an issue. See original summary.

patelmayank7552’s picture

patelmayank7552 commented
Status: Needs work » Needs review
StatusFileSize
new coding_standards-3030001-2.patch1.43 KB

Hi,

I have fixed the coding standard through phpcs.

Please review it.

Attach the patch file : coding_standards-3030001-2.patch

Thanks.

patelmayank7552’s picture

patelmayank7552 commented
Issue summary: View changes
andrew_tspkh’s picture

andrew_tspkh
Primary language Ukrainian
commented
StatusFileSize
new anonymou_login_codding_standarts-3030001-4.patch2.18 KB

Hi @patelmayank7552
Thanks for a phpcs check, but inform you that in module_name.api.php we show representation example of a new hook, but not an implementation of it. The implementation must be used in other modules which need to change (alter) anonymous login paths.
New patch attached.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Patch looks good.

  • andrew_tspkh committed 2e7b8a0 on 8.x-1.x 
    Issue #3030001 by BramDriesen, patelmayank7552, andrew_tspkh: Coding...
andrew_tspkh’s picture

andrew_tspkh
Primary language Ukrainian
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.