Problem/Motivation

Related to https://www.drupal.org/project/paragraphs/issues/3012053, we found out that settingsSummary() in ParagrapsStylePlugin returns an imploded string with the style plugins.

Proposed resolution

We need to return an array with rendered strings in order to properly display the settings in the paragraphs summary.

This should also be done for ParagraphsGridLayoutPlugin. (not sure about ParagraphsLockablePlugin?)

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 interdiff-3029996-7-9.txt5.01 KBjohnchque
#9 3029996-return-arrays-in-settings-summary-9.patch10.31 KBjohnchque
#7 interdiff-3029996-5-7.txt508 bytesjohnchque
#7 3029996-return-arrays-in-settings-summary-7.patch4.67 KBjohnchque
#5 interdiff-3029996-3-5.txt3.93 KBjohnchque
#5 3029996-return-arrays-in-settings-summary-5.patch4.67 KBjohnchque
#3 3029996-return-arrays-in-settings-summary-3.patch1.55 KBsasanikolic

Comments

sasanikolic created an issue. See original summary.

sasanikolic’s picture

sasanikolic commented
Related issues: +#3012053: Split summary into content and behavior parts, show content/behavior only summary when switching between content and behaviors
sasanikolic’s picture

sasanikolic commented
Status: Active » Needs review
StatusFileSize
new 3029996-return-arrays-in-settings-summary-3.patch1.55 KB

Here is the patch.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work

As discussed, we should figure out if we can pass up render arrays and let the parent renderer do its recursion job. We should avoid direct render() calls.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Needs review
StatusFileSize
new 3029996-return-arrays-in-settings-summary-5.patch4.67 KB
new interdiff-3029996-3-5.txt3.93 KB

Updating the structure with the latest changes in Paragraphs.

Status: Needs review » Needs work

The last submitted patch, 5: 3029996-return-arrays-in-settings-summary-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Needs review
StatusFileSize
new 3029996-return-arrays-in-settings-summary-7.patch4.67 KB
new interdiff-3029996-5-7.txt508 bytes

We need to do this update after the last patch.

Status: Needs review » Needs work

The last submitted patch, 7: 3029996-return-arrays-in-settings-summary-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Needs review
StatusFileSize
new 3029996-return-arrays-in-settings-summary-9.patch10.31 KB
new interdiff-3029996-7-9.txt5.01 KB

This should fix all tests.

  • Berdir committed af6632d on 8.x-1.x authored by yongt9412 
    Issue #3029996 by yongt9412, sasanikolic: Return arrays in settings...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Great, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.