Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Feb 2019 at 05:57 UTC
Updated:
19 May 2019 at 09:05 UTC
Jump to comment: Most recent
Comments
Comment #2
sumit-k commentedComment #3
avpadernoThank you for your contribution!
7.x-1.0 is not a correct branch name. It is a correct tag name, but there cannot be a branch and a tag with the same name. The 7.x-1.0 branch needs to be removed.
Comment #4
sumit-k commentedComment #5
sumit-k commentedHi kiamlaluno,
Thanks for review . As mentioned i changed the branch.
Comment #6
sumit-k commentedComment #7
alexdmccabeHi @bsumit5577,
First of all, the module appears to work - no configuration required as promised by the README.
You do have some results to review from pareview: https://pareview.sh/pareview/https-git.drupal.org-project-commerce_remov...
Using
arg()isn't a great practice, but I also can't think of any other way to accomplish what you're trying to do, other than maybe callingmenu_get_item()and checking page callbacks, but that seems unreliable.I would also recommend adding more dependencies to your module - I found it difficult to test because I had to enable several more commerce modules, for instance, the cart module.
In your README.txt you have some unnecessary line wrapping under the "INSTALLATION" section. I would also provide a link as per https://www.drupal.org/node/2181737, maybe something like:
But finally, I'm not 100% certain that the module is necessary - could you not just use the default Sales Tax type that the Commerce Tax module provides, or create a new tax type that does not have the "Display taxes of this type inclusive in product prices" option checked?
Comment #8
alexdmccabeComment #9
avpadernoIf you are still interested on being able to opt into security coverage for projects you create, please open a new application using a project for which the only commits (for the time required to set the application's status to Fixed) are from you.
Please don't open a new application if you aren't sure to have time to dedicate to the application, or it will be closed again as won't fix.
I am closing this application due to lack of activity.