iTunes Category with ampersand outputs extra "amp;" text

I experienced the same.

The text is already htmlencoded and the podcast module encodes it again and the the render system for the attributes.

Here is my suggestions for changing the code

+1 for the patch in #2.

Patch applied for testing.

I haven't run into any problems so far. Thumbs up!

However, I will mention that this issue is making it difficult to test this fully as the itunes:category field isn't being rendered properly.

I really appreciate the podcast module. I've applied three other patches successfully, but the multiple top-level categories patch is failing.

I'm using:

• Drupal 8.8.0.
• Podcast 8.x-1.0
• Patch: https://www.drupal.org/files/issues/2019-07-25/Channel_Information_Not_P...
• Patch: https://www.drupal.org/files/issues/2019-05-06/podcast-setup_image-30349...
• Patch: https://www.drupal.org/files/issues/2019-03-27/3029877-2.patch

https://www.drupal.org/files/issues/2019-05-02/podcast-3052077-multi_top_level_categories-7.patch (iTunes supports multiple top-level categories)
patch '-p1' --no-backup-if-mismatch -d 'web/modules/contrib/podcast' < '/var/folders/02/g3wl6xpj5hn6z0n4x2g650m00000gn/T/5e29ccdc48e5a.patch'
patching file src/Plugin/views/style/Rss.php
Hunk #1 succeeded at 297 (offset 39 lines).
Hunk #2 FAILED at 310.
Hunk #3 FAILED at 336.

2 out of 3 hunks FAILED -- saving rejects to file src/Plugin/views/style/Rss.php.rej

patch '-p0' --no-backup-if-mismatch -d 'web/modules/contrib/podcast' < '/var/folders/02/g3wl6xpj5hn6z0n4x2g650m00000gn/T/5e29ccdc48e5a.patch'
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/Plugin/views/style/Rss.php b/src/Plugin/views/style/Rss.php
|index 3cb4fd1..89f7466 100644
|--- a/src/Plugin/views/style/Rss.php
|+++ b/src/Plugin/views/style/Rss.php
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.

3 out of 3 hunks ignored

patch '-p2' --no-backup-if-mismatch -d 'web/modules/contrib/podcast' < '/var/folders/02/g3wl6xpj5hn6z0n4x2g650m00000gn/T/5e29ccdc48e5a.patch'
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/Plugin/views/style/Rss.php b/src/Plugin/views/style/Rss.php
|index 3cb4fd1..89f7466 100644
|--- a/src/Plugin/views/style/Rss.php
|+++ b/src/Plugin/views/style/Rss.php
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.

3 out of 3 hunks ignored

patch '-p4' --no-backup-if-mismatch -d 'web/modules/contrib/podcast' < '/var/folders/02/g3wl6xpj5hn6z0n4x2g650m00000gn/T/5e29ccdc48e5a.patch'
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/Plugin/views/style/Rss.php b/src/Plugin/views/style/Rss.php
|index 3cb4fd1..89f7466 100644
|--- a/src/Plugin/views/style/Rss.php
|+++ b/src/Plugin/views/style/Rss.php
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.

3 out of 3 hunks ignored

Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2019-05-02/podcast-3052077-multi_top_level_categories-7.patch

This is the first time I've added a patch on my own. I hope posting here was the correct next move.

@fozzieblue,

Can you take a peek at this issue? Essentially, I would like to confirm that you have copied the theme files from the module's templates folder to the active theme's directory?

@shane-birley

Thanks for replying! Yes, I've copied all 5 of the templates from the podcast module templates folder into our custom theme's templates > views folder (themes > custom > npl > templates > views). I did that before I added the three patches that were successful.

Applied the patch at #2

Thank you for testing!