Problem/Motivation

Now that we have JavaScript test base in core, themes might be interested in providing tests. This is the case for the new Drupal Core theme Claro for example which is worked on in a contrib project.

Proposed resolution

Add themes to the phpunit whitelist and make any other changes necessary to allow themes to provide tests.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#7 3029167-6.patch3.1 KBlendude
#2 3029167-1.patch508 byteslauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new 3029167-1.patch508 bytes
lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Issue tags: +Needs tests

Makes sense to me.

This needs tests. Something added to \Drupal\Tests\simpletest\Unit\TestDiscoveryTest?

dawehner’s picture

dawehner
Primary language German
commented

This needs tests. Something added to \Drupal\Tests\simpletest\Unit\TestDiscoveryTest?

That would be nice indeed. It feels like some actual implementation of such a test inside a theme would be dramatically helpful as well.
Otherwise, who knows whether this actually works.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented

It feels like some actual implementation of such a test inside a theme would be dramatically helpful as well.

Yeah but if it is never discovered, it is never run, and it never fails, so that would give little guarantee by itself. But yeah, it would be a nice addition along with the TestDiscoveryTest test.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

I looked at \Drupal\Tests\simpletest\Unit\TestDiscoveryTest but it seemed specific to Simpletest. I'm wondering if we have to add support for Simpletest as well or if it would be enough that the tests can be discovered using PHPUnit.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new 3029167-6.patch3.1 KB

@lauriii I already wrote something for \Drupal\Tests\simpletest\Unit\TestDiscoveryTest, but it passes without the fix too, so its not really testing that. So was looking for a way to test the actual fix, but got distracted :)

Here is what I had so far.

Status: Needs review » Needs work

The last submitted patch, 7: 3029167-6.patch, failed testing. View results

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

dcam’s picture

dcam commented
Status: Needs work » Closed (outdated)

The phpunit.xml.dist changes that permitted scanning themes were added in #3417066: Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.