This patch adds some missing RTL adjustments for the umami demo.

You can easily change your own site to RTL for testing by installing the language module and setting the text direction there

1. .read-more__link
arrow needs to be reversed and to be placed left instead of right
core\profiles\demo_umami\themes\umami\css\components\navigation\more-link\more-link.css

2. Recipe Collections
list items text should be aligned right
core\profiles\demo_umami\themes\umami\css\components\blocks\recipe-collections\recipe-collections.css

3. Footer
Text should be aligned right
core\profiles\demo_umami\themes\umami\css\components\regions\footer\footer.css

4. Copyright and Disclaimer
Text should be aligned right
core\profiles\demo_umami\themes\umami\css\components\blocks\disclaimer\disclaimer.css

5. Toolbar Warning in admin
Icon should be on the right

CommentFileSizeAuthor
#11 3028771-5-after.png15.25 KBsmaz
#11 3028771-5-before.png15.23 KBsmaz
#11 3028771-4-after.png46.71 KBsmaz
#11 3028771-4-before.png55.02 KBsmaz
#11 3028771-3-after.png444.91 KBsmaz
#11 3028771-3-before.png448.84 KBsmaz
#11 3028771-2-after.png81.4 KBsmaz
#11 3028771-2-before.png84.57 KBsmaz
#11 3028771-1-after.png24.49 KBsmaz
#11 3028771-1-before.png54.53 KBsmaz
#10 RTL-changes-in-umami-3028771-9.patch4.67 KBkjay
#8 umami-RTL-recipes.jpg999.93 KBshaal
#8 umami-RTL-articles.jpg661.18 KBshaal
#8 umami-RTL-homepage.jpg1.3 MBshaal
#8 interdiff_6-8.txt5.04 KBshaal
#8 RTL-changes-in-umami-3028771-8.patch4.67 KBshaal
#6 interdiff_5-6.txt1.27 KBshaal
#6 RTL-changes-in-umami-3028771-6.patch5.24 KBshaal
#5 RTL-changes-in-umami-3028771-5.patch3.15 KBpawandubey
#5 RTL-changes-in-umami-3028771-5.png3.29 MBpawandubey
#3 0002-RTL-changes-in-umami.patch3.79 KBNot Real
rtl-css-umami-changes.patch6.59 KBNot Real
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Not Real created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, rtl-css-umami-changes.patch, failed testing. View results

Not Real’s picture

Not Real CreditAttribution: Not Real commented
FileSize
0002-RTL-changes-in-umami.patch3.79 KB

Fix whitespaces

John Cook’s picture

John Cook CreditAttribution: John Cook at Creode commented
Status: Needs work » Needs review
pawandubey’s picture

pawandubey CreditAttribution: pawandubey as a volunteer and at TATA Consultancy Services commented
FileSize
RTL-changes-in-umami-3028771-5.png3.29 MB
RTL-changes-in-umami-3028771-5.patch3.15 KB

@Not Real

The patch works fine for me and attached is the screenshot for the same.

Meanwhile, I just re-rolled the patch to fix the end line issue as per coding standards.

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
CreditAttribution: shaal as a volunteer commented
FileSize
RTL-changes-in-umami-3028771-6.patch5.24 KB
interdiff_5-6.txt1.27 KB

I based my changes on #5 patch.
in RTL - Disclaimer section, disclaimer paragraph should be on the right, and copyright section should be on the left.

Eli-T’s picture

Eli-T
he/him
Primary language English
Location Manchester
CreditAttribution: Eli-T commented
Status: Needs review » Needs work

Thanks for updating this issue. However it looks like this patch touches things outside Umami's CSS,for example core/lib/Drupal/Core/Database/Query/AlterableInterface.php.

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
CreditAttribution: shaal as a volunteer commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
RTL-changes-in-umami-3028771-8.patch4.67 KB
interdiff_6-8.txt5.04 KB
umami-RTL-homepage.jpg1.3 MB
umami-RTL-articles.jpg661.18 KB
umami-RTL-recipes.jpg999.93 KB

Yikes. I think these were some rookie mistakes... sorry about that.

I updated the patch by removing unrelated code changes and added additional /* LTR */ inline comments as required by CSS formatting guidelines.

Homepage RTL screenshot:
umami-RTL-homepage

Articles RTL screenshot:
umami-RTL-articles

Recipes RTL screenshot:
umami-RTL-recipes.jpg

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

kjay’s picture

kjay CreditAttribution: kjay commented
FileSize
RTL-changes-in-umami-3028771-9.patch4.67 KB

Patch required reroll (see attached).

Patch tested and looks good in relation to addressing the points raised in the issue summary.

smaz’s picture

smaz
Primary language English
Location England, UK
CreditAttribution: smaz at Five Mile Media commented
Status: Needs review » Reviewed & tested by the community
FileSize
3028771-1-before.png54.53 KB
3028771-1-after.png24.49 KB
3028771-2-before.png84.57 KB
3028771-2-after.png81.4 KB
3028771-3-before.png448.84 KB
3028771-3-after.png444.91 KB
3028771-4-before.png55.02 KB
3028771-4-after.png46.71 KB
3028771-5-before.png15.23 KB
3028771-5-after.png15.25 KB

Tested: Patch applies cleanly, code looks ok & styles work as expected - all issues in the issue summary have been taken care of.

1. .read-more__link: arrow needs to be reversed and to be placed left instead of right
Before:
view recipe link - before

After:
view recipe link - after

2. Recipe Collections: list items text should be aligned right
Before:
recipe collections - before

After:
recipe collections - after

3. Footer: Text should be aligned right
Before:
footer text - before

After:
footer text - after

4. Copyright and Disclaimer: Text should be aligned right
Before:
copyright / disclaimer - before

After:
copyright / disclaimer - after

5. Toolbar Warning in admin: Icon should be on the right
Before:
admin toolbar icon - before

After:
admin toolbar icon - after

  • Gábor Hojtsy committed e610f4e on 8.8.x 
    Issue #3028771 by shaal, Not Real, pawandubey, kjay, smaz, Eli-T: Add...

  • Gábor Hojtsy committed 303ea60 on 8.7.x 
    Issue #3028771 by shaal, Not Real, pawandubey, kjay, smaz, Eli-T: Add...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.