This patch adds some missing RTL adjustments for the umami demo.
You can easily change your own site to RTL for testing by installing the language module and setting the text direction there
1. .read-more__link
arrow needs to be reversed and to be placed left instead of right
core\profiles\demo_umami\themes\umami\css\components\navigation\more-link\more-link.css
2. Recipe Collections
list items text should be aligned right
core\profiles\demo_umami\themes\umami\css\components\blocks\recipe-collections\recipe-collections.css
3. Footer
Text should be aligned right
core\profiles\demo_umami\themes\umami\css\components\regions\footer\footer.css
4. Copyright and Disclaimer
Text should be aligned right
core\profiles\demo_umami\themes\umami\css\components\blocks\disclaimer\disclaimer.css
5. Toolbar Warning in admin
Icon should be on the right
Comment | File | Size | Author |
---|---|---|---|
#11 | 3028771-5-after.png | 15.25 KB | smaz |
#11 | 3028771-5-before.png | 15.23 KB | smaz |
#11 | 3028771-4-after.png | 46.71 KB | smaz |
#11 | 3028771-4-before.png | 55.02 KB | smaz |
#11 | 3028771-3-after.png | 444.91 KB | smaz |
Comments
Comment #3
Not Real CreditAttribution: Not Real commentedFix whitespaces
Comment #4
John Cook CreditAttribution: John Cook at Creode commentedComment #5
pawandubey CreditAttribution: pawandubey as a volunteer and at TATA Consultancy Services commented@Not Real
The patch works fine for me and attached is the screenshot for the same.
Meanwhile, I just re-rolled the patch to fix the end line issue as per coding standards.
Comment #6
shaalI based my changes on #5 patch.
in RTL - Disclaimer section, disclaimer paragraph should be on the right, and copyright section should be on the left.
Comment #7
Eli-TThanks for updating this issue. However it looks like this patch touches things outside Umami's CSS,for example core/lib/Drupal/Core/Database/Query/AlterableInterface.php.
Comment #8
shaalYikes. I think these were some rookie mistakes... sorry about that.
I updated the patch by removing unrelated code changes and added additional
/* LTR */
inline comments as required by CSS formatting guidelines.Homepage RTL screenshot:
Articles RTL screenshot:
Recipes RTL screenshot:
Comment #10
kjay CreditAttribution: kjay commentedPatch required reroll (see attached).
Patch tested and looks good in relation to addressing the points raised in the issue summary.
Comment #11
smazTested: Patch applies cleanly, code looks ok & styles work as expected - all issues in the issue summary have been taken care of.
1. .read-more__link: arrow needs to be reversed and to be placed left instead of right
Before:
After:
2. Recipe Collections: list items text should be aligned right
Before:
After:
3. Footer: Text should be aligned right
Before:
After:
4. Copyright and Disclaimer: Text should be aligned right
Before:
After:
5. Toolbar Warning in admin: Icon should be on the right
Before:
After:
Comment #14
Gábor HojtsyThanks all!