Fix coding standards messages

The "Needs work" is a testbot problem, when it didn't find any tests (because there aren't any!). It's not because of coding standards.

See #2990645: "Build Successful" is treated as a test failure

Coding standards problems don't cause test failures. But yes, it would be nice to fix them. (There are only 34 ...) Not all of the reported violations should be fixed however - you have to use some discretion.

Not all of the reported violations should be fixed however

For example, your change to README.txt - that code sample should be left indented. Also, commented out code will generate some violations, but should not be removed or modified just to satisfy coder.

Also, the patch should be ONLY coding standards - please refrain from making structural changes like you did with the conditional statements. Those should be handled in a different issue. (And the removal of the patch file already has an issue open, so that should not be included here ...)

You should use your modified version of the module for a while - I'm pretty sure adding the type hints to functions not defined by this module will cause problems because adding a type hint changes the function signature so the function won't match how it's defined in core

Here an updated patch, matching latest dev version.

Another iteration.

Remaining coding errors left intentionally. Committing.