Comments

ljcarnieri created an issue. See original summary.

yago elias’s picture

Issue summary: View changes

  • Yago Elias authored 63a4f53 on 8.x-2.x
    Issue #3028082 by ljcarnieri, Yago Elias: Janrain account delete
    
  • ljcarnieri authored 8c6b3d4 on 8.x-2.x
    Issue #3028082 by ljcarnieri, yago-elias: Janrain account delete
    
renatog’s picture

Assigned: ljcarnieri » Unassigned
Status: Active » Needs work
File: janrain_connect/modules/janrain_connect_admin_services/src/Service/JanrainConnectAdminServicesCalls.php
Line: 65

Change comment: "Delete entity from Janrain." because this function will not delete entity on janrain.
Suggestion: "Entity Delete on Janrain."

File: janrain_connect/src/Service/JanrainConnectConnector.php
Line: 115

Description: Change function name from "getFullClient" to "getDirectClient"
Reason: "fullAccess" is "Owner" on Janrain and in Super Admin we're using Direct Access.
P.s. Update the code with these call. E.g:
From: $full_client = $this->getFullClient();
To: $direct_client = $this->getDirectClient();

yago elias’s picture

Issue summary: View changes
Status: Needs work » Needs review

see commit 65968e4b01bc82d6bec61780d1f6b06ec9defc16

renatog’s picture

Status: Needs review » Reviewed & tested by the community

Checked: https://cgit.drupalcode.org/janrain_connect/commit/?id=65968e4b01bc82d6bec61780d1f6b06ec9defc16 and really works good!

Thank you very much @Yago and @ljcarnieri

renatog’s picture

Status: Reviewed & tested by the community » Fixed

  • 65968e4 committed on 8.x-2.x
    Issue #3028082 by ljcarnieri, Yago Elias, RenatoG: Janrain account...

  • 09fcccd committed on 8.x-2.x
    Issue #3028082 by RenatoG, Yago Elias, ljcarnieri: Janrain account...

  • a4b97b9 committed on 8.x-2.x
    Issue #3028082 by RenatoG, Yago Elias, ljcarnieri: Janrain account...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.