Currently the system only shows the confirmation page w/ few information from ServerTemplate when a user click the Launch tab in a ServerTemplate.

The detail information like ServerTemplate editable view should be shown as the final confirmation when a user try to launch an instance from ServerTemplate.

Or, just add an Edit button with the non-editable fields.

CommentFileSizeAuthor
#15 3027974-15.patch7.87 KBxiaohua guan
#13 3027974-13.patch7.87 KBxiaohua guan
#9 3027974-9.patch7.27 KBxiaohua guan
#8 3027974-8.patch6.61 KBxiaohua guan
#7 3027974-7.patch6.63 KBxiaohua guan
#5 screenshot1.png258.22 KByas
#2 3027974-2.patch1.05 KBxiaohua guan

Comments

Xiaohua Guan created an issue. See original summary.

xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3027974-2.patch1.05 KB
xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review

@yas

I simplely add entity view of server template to the launch form.

Please review the patch. Thanks.

xiaohua guan’s picture

xiaohua guan commented
Title: Add details to server template lauch form » Add details to server template launch form
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
StatusFileSize
new screenshot1.png258.22 KB

@xiaohua-guan,

Thank you for the patch！ I would like to ask you to do some refactoring as shown below:

  1. Add Fieldset titled Automation for termination and schedule options
  2. Put a label Name: before ServerTemplate name _OR_ just simply not display the ServerTemplate name here
  3. Add Fieldsets by changing the order of items similarly like Instance Detailed View Page

screenshot1

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3027974-7.patch6.63 KB
xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3027974-8.patch6.61 KB
xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3027974-9.patch7.27 KB
xiaohua guan’s picture

xiaohua guan commented

@yas

I modified the code as you said. Please review the patch. Thanks.

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan,

It is so nice, but I'd like to ask my request to you as one more thing, let's align the ServerTemplate detail view page (*) as the same Look & Feel as the Launch form like your patch #9.

* route path: /clouds/design/server_template/{cloud_context}/{id}

xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3027974-13.patch7.87 KB
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

I modified ServerTemplate detail view page. Please review the patch file. Thanks.

xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3027974-15.patch7.87 KB
xiaohua guan’s picture

xiaohua guan commented

@yas

I attached a new patch file. Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan,

Thank you for the updated patch. It is perfect to me now.

@baldwinlouie,

What do you think?

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@yas, @xiaohua-guan Looks good! RTBC!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie,

Thank you for your review. I'll merge the patch and close this issue as Fixed.

  • yas committed d2fce16 on 8.x-1.x authored by Xiaohua Guan 
    Issue #3027974 by Xiaohua Guan, yas, baldwinlouie: Add details to server...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.