Follow-up of #3023799: Add @trigger_error() to deprecated EntityManager::clearCachedDefinitions() method, we noticed that a lot of the cache clear calls were not needed anymore. That issue removed all calls that we identified in tests, but there are also some in content_translation for example that do not seem to be necessary.

Investigate and remove them if we can. As pointed out there, they were likely made unnecessary by fixing cache clearing in case of content translation changes in #3008740: ContentTranslationManager::setEnabled no longer clears the bundle info cache when changing a bundle's translation setting..

CommentFileSizeAuthor
#7 content-translation-clear-caches-3026166-7.patch1.43 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Component: entity system » content_translation.module
Status: Reviewed & tested by the community » Active
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Add @trigger_error() to deprecated EntityManager::clearCachedDefinitions() method » Remove necessary EntityTypeManager::clearCachedDefinitions() calls in content_translation
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Parent issue: #3023799: Add @trigger_error() to deprecated EntityManager::clearCachedDefinitions() method »
Related issues: +#3023799: Add @trigger_error() to deprecated EntityManager::clearCachedDefinitions() method
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Remove necessary EntityTypeManager::clearCachedDefinitions() calls in content_translation » Remove unnecessary EntityTypeManager::clearCachedDefinitions() calls in content_translation

Creating a follow-up issue is hard...

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new content-translation-clear-caches-3026166-7.patch1.43 KB

Lets see if that works.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Ran #7 for D10 tests and all green.

Think this code refactoring can't hurt.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 278e74c and pushed to 10.1.x. Thanks!

  • catch committed 278e74c9 on 10.1.x 
    Issue #3026166 by Berdir: Remove unnecessary EntityTypeManager::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.