Problem/Motivation

The Umami theme has some CSS overrides for the toolbar module. These were added in earlier issues, where Umami's styles were leaking into the toolbar where they weren't wanted. But these overrides are now split across 2 files.

Proposed resolution

Move all of these toolbar CSS overrides into one file, for easier maintenance.

Remaining tasks

  1. Move the styles from core/profiles/demo_umami/themes/umami/css/components/navigation/toolbar/toolbar.css into core/profiles/demo_umami/themes/umami/css/components/toolbar/toolbar.css
  2. Remove the css/components/navigation/toolbar/toolbar.css entry from umami.libraries.yml
  3. Write a patch.

User interface changes

None.

API changes

None.

Data model changes

None,

Issue fork drupal-3024056

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andrewmacpherson created an issue. See original summary.

andrewmacpherson’s picture

andrewmacpherson commented
Issue summary: View changes
Issue tags: +Novice, +ContributionWeekend2019

This will make a good first-time contribution, perhaps during the upcoming Global Contribution Weekend 2019 later this month.

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Active » Postponed
Related issues: +#2992635: Pass all Umami CSS files through CSScomb to Ensure they Follow our CSS Coding Standards

Postponing on #2992635: Pass all Umami CSS files through CSScomb to Ensure they Follow our CSS Coding Standards - we want to get the comb implemented before making further changes.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Postponed » Active

No longer postponed.

ankitv18 made their first commit to this issue’s fork.

ankitv18 opened merge request !9057

ankitv18’s picture

ankitv18 commented
Status: Active » Needs review

Please review MR!9057

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward

Shame new users never picked it up before

ankitv18’s picture

ankitv18 commented

This issue is a quite a old one postponing from one version to another, finally if it can move fast forward then what's the shame in that.
Why keep hanging these kind of issue any further more.

  • catch committed d7b1b1bc on 11.x 
    Issue #3024056 by ankitv18, andrewmacpherson: Organize Umami's toolbar...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

catch closed merge request !9057

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.