I can get to the "find usages" stage (/admin/config/media/duplicate-images?op=usages) OK. I find 1005 duplicates and 2636 suspicious images. However, when I click on "Find" and get to admin/config/media/duplicate-images?op=update, it appears that there are no entities to be updated.

The following PHP notices and warning appears in the logs:

Notice: Undefined index: entity_update_instructions in DuplicateImagesUpdate->fields() (line 46 of drupal/7/sites/example.org/modules/duplicate_images/DuplicateImagesUpdate.php).
Notice: Undefined index: duplicate_references in DuplicateImagesUpdate->fields() (line 47 of drupal/7/sites/example.org/modules/duplicate_images/DuplicateImagesUpdate.php).
Notice: Undefined index: duplicate_managed_files in DuplicateImagesUpdate->fields() (line 48 of drupal/7/sites/example.org/modules/duplicate_images/DuplicateImagesUpdate.php).
Warning: Invalid argument supplied for foreach() in DuplicateImagesUpdate->fields() (line 52 of drupal/7/sites/example.org/modules/duplicate_images/DuplicateImagesUpdate.php).

I have tried to do a bit of debugging using the watchdog, and it seems that duplicate_images_get_form_submit() is not being called when the form on /admin/config/media/duplicate-images?op=usages is submitted. Looking at the module's code, this would account for the errors above.

However, I'm stuck now - I am wondering if there is a problem with there being so many images in the form, or if some change to Drupal has stopped the existing code working correctly. I am using various other modules on my site, but I'm not clear how they could interfere.

Comments

egfrith created an issue. See original summary.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented

Just guessing I think this may have to do with the PHP setting

; How many GET/POST/COOKIE input variables may be accepted
max_input_vars = 2500

This is from my php.ini but with so many suspicious duplicates I think that even this value is not enough. Try 50000 or something like that.

egfrith’s picture

egfrith commented

Many thanks - increasing max_input_vars works. I wonder if it would be worth setting a warning message suggesting increasing max_input_vars if entity_update_instructions is undefined.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented

You could use the setting 'Maximum number of duplicate images to process' to reduce the number of fields on the subsequent forms. It already warns for max_execution_time, but I will also add max_input_vars as a setting to consider to the help text.

  • fietserwin committed 9cb1a83 on 7.x-1.x 
    Issue #3023520 by fietserwin: Add max_imput_vars to the help as a...
fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.