Not Recognizing Matching Pattern

I just tried it on a test site and it works as expected for me, at least under PHP 5.6. I don't think the PHP version would matter. Please verify that there is not additional whitespace in either the pattern or the test data.

Please try changing your PHP version to see if that is actually the problem. You could try to reproduce just the validation snippet on another server; see webform_validation.validators.inc.

Is this still a problem?

If this is still a problem please re-open and provide details.

I've got the same issue. Trying to validate a postalcode useing "#### @@" validator.
This always fails.

It's a site of a client and they just started noticing this. We went from php 7.0X to 7.3X last week, but i can't easily change it back to test.

I can't reproduce this problem in my test environment on either PHP 5.6 or PHP 7.2. I suggest downgrading PHP to see if that is the problem. Or add debugging code to see why it is failing.

Since i had some spare time, i fired up an old cluster with PHP 7.0.x to test with.
I created a webform with a single textfield, added a pattern validation of "#### @@" and tried to enter data.

On PHP 7.0.x this works as intended; 1234AB doesn't get validated, 1234 AB is valid.

Switching back to our new cluster with PHP 7.3.4, the exact same page doesn't validate 1234AB as well as 1234 AB so the php version would seem the culprit.
Sadly no errors in the logs or in drupal. It would seem the methods used to check the input versus the pattern have changed in this PHP version which results in the validator always returning invalid.

It will take adding some debugging code to see what the difference is.

Any news on this? All pattern validators aren't working for us, which is kinda a pain :)

You could switch to using regex or add some debugging code to try to figure out what is happening.

Using the latest development version of webform_validation, please create a minimal test case.

I just stumbled into this today after we upgraded to PHP 7.3 yesterday. The problem is that preg_quote() changed behavior in 7.3 and now escapes # to \#. When webform_validation_webform_validation_validate() creates $pattern to test the input, # becomes \# becomes \[0-9] (instead of [0-9]) and that regex will never match numbers. Attached is a minimal patch that tests the PHP version and de-escapes "#" in the test pattern.

Thanks for the patch. Instead of duplicating the call to str_replace(), have the line with version_compare() return either '#' or '\#' and use that in the str_replace() call.

Sure.

Based on priority levels for issues, this should be major. All pattern-based validators using # are broken for PHP 7.3+ with no warning to admin and obvious disruption for site visitors. Let's just get the fix in. :)

Happy holidays!

Thanks!