The feature to configure placeholder texts in the Views UI was added in #2917594: Add support for HTML5 placeholder in views exposed filters. However, these placeholders are not translatable because the config schema was set to "string" (not translatable) instead of "label" (translatable).
Fix the config schema to make placeholders translatable.
Review, possibly test.
Do we need to add an update hook that transfers the default language placeholders into any existing views translations?
> No we don't
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | drupal-translatable_placeholders-3023452-11.patch | 1.5 KB | abhishek_v |
| #5 | 3023452-5.patch | 1.51 KB | lendude |
| #5 | interdiff-3023452-2-5.txt | 492 bytes | lendude |
| #2 | drupal-translatable_placeholders-3023452-2.patch | 943 bytes | ckaotik |
Comments
Comment #2
ckaotikPlease review the attached patch.
Comment #3
lendudeComment #4
lendudeSorry that was submitted a little too quickly :)
I just manually tested this and it works fine.
We don't need an upgrade path to add the translation to any existing translations, but we do need one to trigger a cache clear to make this work
Comment #5
lendudehere we go.
Comment #6
ckaotikAwesome, thank you! Guess I just learned how to do a cache rebuild during updates :D
Comment #7
rajab natshahComment #8
gábor hojtsyComment #10
gábor hojtsyThanks, committed to 8.7.x, does not apply to 8.6.x unfortunately.
Comment #11
abhishek_v commentedI modified the placeholder datatype to label in version 8.6.x and added the cache function provided in ckaotik's patch. This seemed to make the placeholder text translatable. Please review the patch.
Comment #12
alexpottThe 8.6.x branch is now closed for bugfixes. This will be released as bugfix in 8.7.0. Thanks @abhishek_v for your contribution unfortunately there was not time to get this in.
Comment #13
alexpott