Problem/Motivation

The feature to configure placeholder texts in the Views UI was added in #2917594: Add support for HTML5 placeholder in views exposed filters. However, these placeholders are not translatable because the config schema was set to "string" (not translatable) instead of "label" (translatable).

Proposed resolution

Fix the config schema to make placeholders translatable.

Remaining tasks

Review, possibly test.

Do we need to add an update hook that transfers the default language placeholders into any existing views translations?
> No we don't

CommentFileSizeAuthor
#11 drupal-translatable_placeholders-3023452-11.patch1.5 KBabhishek_v
#5 3023452-5.patch1.51 KBLendude
#5 interdiff-3023452-2-5.txt492 bytesLendude
#2 drupal-translatable_placeholders-3023452-2.patch943 bytesckaotik
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ckaotik created an issue. See original summary.

ckaotik’s picture

ckaotik
Primary language German
Location Berlin
CreditAttribution: ckaotik at werk21 commented
Assigned: ckaotik » Unassigned
Status: Active » Needs review
FileSize
drupal-translatable_placeholders-3023452-2.patch943 bytes

Please review the attached patch.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at ezCompany commented
Issue summary: View changes
Status: Needs review » Needs work
Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at ezCompany commented

Sorry that was submitted a little too quickly :)

I just manually tested this and it works fine.

We don't need an upgrade path to add the translation to any existing translations, but we do need one to trigger a cache clear to make this work

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at ezCompany commented
Status: Needs work » Needs review
FileSize
interdiff-3023452-2-5.txt492 bytes
3023452-5.patch1.51 KB

here we go.

ckaotik’s picture

ckaotik
Primary language German
Location Berlin
CreditAttribution: ckaotik at werk21 commented

Awesome, thank you! Guess I just learned how to do a cache rebuild during updates :D

Rajab Natshah’s picture

Rajab Natshah CreditAttribution: Rajab Natshah at Vardot commented
Status: Needs review » Reviewed & tested by the community
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue summary: View changes

  • Gábor Hojtsy committed b6a1e29 on 8.7.x 
    Issue #3023452 by Lendude, ckaotik: Views placeholder texts are not...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks, committed to 8.7.x, does not apply to 8.6.x unfortunately.

abhishek_v’s picture

abhishek_v CreditAttribution: abhishek_v at Google Summer of Code commented
FileSize
drupal-translatable_placeholders-3023452-11.patch1.5 KB

I modified the placeholder datatype to label in version 8.6.x and added the cache function provided in ckaotik's patch. This seemed to make the placeholder text translatable. Please review the patch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Version: 8.6.x-dev » 8.7.x-dev
Status: Patch (to be ported) » Fixed

The 8.6.x branch is now closed for bugfixes. This will be released as bugfix in 8.7.0. Thanks @abhishek_v for your contribution unfortunately there was not time to get this in.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.