This module adds a class for connecting to a third party API that helps publishers pay freelance contributors (https://outvoice.com). It also adds an optional, basic UI to the node/add/* form for making payments.

Project link

https://www.drupal.org/project/outvoice

Git instructions

git clone --branch 8.x-1.x https://git.drupal.org/project/outvoice.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-outvoice.git

Comments

Mr_Issa created an issue. See original summary.

avpaderno’s picture

Issue summary: View changes

Thank you for your contribution!
I am adding the PAReview checklist link. If you haven't done it yet, please check the reported issues, and fix the code as indicated. Don't pay attention to the false positives the checklist could contain.

Next, the reviewers will check the project code, and report here what needs to be changed.

Mr_Issa’s picture

Thanks, Kiamlaluno! PAReview tests all passing, with the exception of a third party jquery plugin I'm using. Not sure what to do about that, any advice appreciated.

saesa’s picture

Status: Needs review » Needs work

You should review dependency injections.

FILE: ../modules/outvoice_ui/src/Form/OutvoiceSettingsForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
 44 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
--------------------------------------------------------------------------
Mr_Issa’s picture

Dependency Injection removed. Thanks, saesa!

Mr_Issa’s picture

Status: Needs work » Needs review
avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Mr_Issa’s picture

Thanks, everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.