Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
26 Dec 2018 at 20:15 UTC
Updated:
11 Jan 2019 at 19:34 UTC
Jump to comment: Most recent
Comments
Comment #2
avpadernoThank you for your contribution!
I am adding the PAReview checklist link. If you haven't done it yet, please check the reported issues, and fix the code as indicated. Don't pay attention to the false positives the checklist could contain.
Next, the reviewers will check the project code, and report here what needs to be changed.
Comment #3
Mr_Issa commentedThanks, Kiamlaluno! PAReview tests all passing, with the exception of a third party jquery plugin I'm using. Not sure what to do about that, any advice appreciated.
Comment #4
saesa commentedYou should review dependency injections.
Comment #5
Mr_Issa commentedDependency Injection removed. Thanks, saesa!
Comment #6
Mr_Issa commentedComment #7
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #8
Mr_Issa commentedThanks, everyone!