Comments

sgostanyan created an issue. See original summary.

avpaderno’s picture

Issue summary: View changes

Thank you for your contribution!
I am adding the PAReview checklist link. If you haven't done it yet, please check the reported issues, and fix the code as indicated. Don't pay attention to the false positives the checklist could contain.

Next, the reviewers will check the project code, and report here what needs to be changed.

avpaderno’s picture

Title: [D8]Last tweets » [D8] Last tweets
Issue tags: -Needs security review
sgostanyan’s picture

Hi,

PAReview checklist says "Git checkout of branch 8.x-1.x failed. Aborting."
What does it mean and how to resolve it?

Many thx.

edit: Ok found the problem, I had to change the branch name.

sgostanyan’s picture

Issue summary: View changes
avpaderno’s picture

It seems the X in the tag name was causing the issue.

sgostanyan’s picture

Issue summary: View changes
sgostanyan’s picture

Issue summary: View changes
sgostanyan’s picture

Issue summary: View changes
Issue tags: +PAreview: review bonus
sgostanyan’s picture

Issue summary: View changes
sgostanyan’s picture

Issue summary: View changes
sgostanyan’s picture

Issue summary: View changes
saesa’s picture

There is no way for tweets to appear without the need for so many keys and tokens? I think it would be easier with just the username if it could be.

sgostanyan’s picture

@saesa, for security reason it's mandatory to send an authenticated request to the API. Only thing you need is to create a Twitter app related to your account, you will get all tokens and secrets, it takes 5 minutes to accomplish this. All social network APIs work like that.

sgostanyan’s picture

Hi kiamlaluno,

Do you know how long do I still wait? I know It depends on volunteers but I already reviewed 6 projects, some of them have the security advisory covered now. My project is the only one tagged with "PAReview: review bonus" in the list but no one is reviewing it. I'm waiting for 2 weeks, It's disappointing.

Thx.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.