I refactored code for the RecentlyReadService service and added a new method "deleteEntityRecords" which allows removing Recently Read records for the desired entity with or without relation to the desired user.

CommentFileSizeAuthor
#8 recently_read-RecentlyReadService_changes-3022174-8-D8.patch.patch8.97 KBnikita_tt
#7 Screenshot from 2019-01-03 21-15-10.png24.56 KBvipul tulse
#3 recently_read-RecentlyReadService_changes-3022174-3-D8.patch8.93 KBnikita_tt
#2 recently_read-RecentlyReadService_changes-3022174-2-D8.patch7.3 KBnikita_tt

Comments

nikita_tt created an issue. See original summary.

nikita_tt’s picture

nikita_tt
Primary language Ukrainian
commented
StatusFileSize
new recently_read-RecentlyReadService_changes-3022174-2-D8.patch7.3 KB
nikita_tt’s picture

nikita_tt
Primary language Ukrainian
commented
StatusFileSize
new recently_read-RecentlyReadService_changes-3022174-3-D8.patch8.93 KB

Sorry. This is the correct patch file.

vipul tulse’s picture

vipul tulse commented
Status: Active » Needs review

Please unsaasigned yourself from ticket so that I can verify review the ticket

nikita_tt’s picture

nikita_tt
Primary language Ukrainian
commented
Assigned: nikita_tt » Unassigned
vipul tulse’s picture

vipul tulse commented
Assigned: Unassigned » vipul tulse
vipul tulse’s picture

vipul tulse commented
StatusFileSize
new Screenshot from 2019-01-03 21-15-10.png24.56 KB

Hello

I have tried to apply patch got the error.

Can you please verify, error screenshot is attached.

nikita_tt’s picture

nikita_tt
Primary language Ukrainian
commented
StatusFileSize
new recently_read-RecentlyReadService_changes-3022174-8-D8.patch.patch8.97 KB

Please try this one.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Assigned: vipul tulse » Unassigned
Status: Needs review » Reviewed & tested by the community

I have tested the patch and it applies cleanly and works correctly. Minor coding standards are fixed and new delete method is added. Marking it as RTBC.

  • nkoporec committed 19bb29d on 8.x-1.x authored by nikita_tt 
    Issue #3022174 by nikita_tt: RecentlyReadService changes/improvements
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Reviewed & tested by the community » Fixed

commited, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.