Problem/Motivation

The VoteCreationTest and VoteTest classes were made with Simpletest but this test framework is deprecated in favor of PHPUnit.

Proposed resolution

Convert the VoteCreationTest and VoteTest classes to PHPUnit.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 votingapi-convert_simpletest_to_phpunit-3021997-3.patch11.64 KBandralex
#2 votingapi-convert_simpletest_to_phpunit-3021997-2.patch11.27 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Title: Convert remaining Simpletests to PHPUnit » Convert automated tests from Simpletest to PHPUnit
Status: Active » Needs review
StatusFileSize
new votingapi-convert_simpletest_to_phpunit-3021997-2.patch11.27 KB

Attached patch converts the automated tests from Simpletest to PHPUnit

andralex’s picture

andralex commented
StatusFileSize
new votingapi-convert_simpletest_to_phpunit-3021997-3.patch11.64 KB

Tested the patch and found a list of deprecations. Here is an updated patch version.

alex_optim’s picture

alex_optim
Location Tallinn
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented

  • pifagor committed 1ca6210 on 8.x-3.x authored by andralex 
    Issue #3021997 by idebr, andralex, alex_optim, pifagor: Convert...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.