Problem/Motivation

From #2244513: Move the unmanaged file APIs to the file_system service (file.inc)

* the file status constant, that should be a separate issue to move it to FileInterface.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 3021653-8.patch104.17 KBandypost
#8 interdiff.txt493 bytesandypost
#3 3021653-3.patch104.01 KBandypost

Comments

kim.pepper created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Assigned: Unassigned » andypost 
$ git grep  FILE_STATUS_PERMANENT | wc -l
41
$ git grep FILE_CREATE_DIRECTORY | wc -l
48
$ git grep FILE_MODIFY_PERMISSIONS|wc -l
26
$ git grep FILE_EXISTS_RENAME|wc -l
61
git grep FILE_EXISTS_REPLACE|wc -l
67
git grep FILE_EXISTS_ERROR| wc -l
47
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 3021653-3.patch104.01 KB

Changed in code, still some leftovers in docs

andypost’s picture

andypost
he/him
Primary language Russian
commented
Assigned: andypost » Unassigned

It has a lot of intersections with #2244513: Move the unmanaged file APIs to the file_system service (file.inc)

Also FILE_STATUS_PERMANENT probably needs to be moved to \Drupal\file\FileInterface

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Move file status constant to FileInterface » Move file status constant to FileSystemInterface
andypost’s picture

andypost
he/him
Primary language Russian
commented

Filed #3021833: Move FILE_STATUS_PERMANENT to \Drupal\file\FileInterface

Status: Needs review » Needs work

The last submitted patch, 3: 3021653-3.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt493 bytes
new 3021653-8.patch104.17 KB

Fix tests

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

No, this issue is only about the file status constant. All others are converted over there.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

Filed #3021833: Move FILE_STATUS_PERMANENT to \Drupal\file\FileInterface

That's what this issue was originally for. :-)

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
Status: Needs review » Closed (duplicate)

Let's move to #3021833: Move FILE_STATUS_PERMANENT to \Drupal\file\FileInterface