From #2244513: Move the unmanaged file APIs to the file_system service (file.inc)

The level of nesting that's going on in those file system calls is pretty mindblowing and "fun" to debug as we call into the LocalStream implementation, which then goes through the deprecated functions back into the file_system service where the real action finally happens. We should create an issue to add @trigger_error()'s to the already deprecated functions in file.inc and convert them.

Comments

kim.pepper created an issue. See original summary.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Related issues: +#3021450: Add @trigger_error to deprecated functions in file.inc and replace their usages
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

@voleger I don't think we need to split these up into separate issues. They seem small enough.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

Not sure about that, because during simple replacement I faced with an interesting issue. In #3021434: Properly deprecate drupal_unlink() test shows Circular reference detected for service file_system, because file_system service requires logger.channel.file that have dependency on the file_system service...
I think small patches will help to fix most of the other functions during resolving of such issues that I mentioned above.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Closed (duplicate)

Maybe something inbetween? Do the ones that are bigger/complicated in separate issues, but the trivial ones like rarely used drupal_tempnam() in one?

Either way, I guess this is a duplicate, whether or not the other issue actually is only a meta or not.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

Yep. Looks like @voleger's issue was created 15hrs before this one. :-)