README.md file is empty. There should be one.

This is especially important since it doesn't have a regular config settings form route, and it should be made clear that you need to go to /admin/appearance to update the config settings for admin routes.

CommentFileSizeAuthor
#7 eck-3021609-7.patch1.06 KBoknate
#6 Screen Shot 2018-12-21 at 10.31.28 PM.png17.65 KBvolkswagenchick
#2 eck-3021609-2.patch1.04 KBoknate

Comments

oknate created an issue. See original summary.

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new eck-3021609-2.patch1.04 KB
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Active » Needs review
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Needs work
StatusFileSize
new Screen Shot 2018-12-21 at 10.31.28 PM.png17.65 KB

Thanks for adding documentation. Patch applies locally, but I have a nitpick :)

+++ b/README.md
@@ -0,0 +1,27 @@
+and with useful abstractions (classes, plugins, etc) to help developers use entities with ease.

Line 6 and 28:
Line breaks should be at 80 characters.

Marking as needs work.

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new eck-3021609-7.patch1.06 KB

Thanks for the feedback. Updated.

oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Needs work » Needs review
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community

The patch in #7 applied locally. Thanks for the fix. Marking RTBC

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

Looks good and fit the coding standards of the readme files.

alex_optim’s picture

alex_optim
Location Tallinn
commented

Good for me too.

pifagor’s picture

pifagor commented

  • pifagor committed c53b0ba on 8.x-1.x authored by oknate 
    Issue #3021609 by oknate, volkswagenchick, voleger, alex_optim, pifagor...
pifagor’s picture

pifagor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.