Introduction
Custom panels blocks is a Drupal 8 module which provide the management to add differents blocks, fields or any kind of plugins availables for the module contrib Panels by the different roles of your platform.

It allows the possibility to add different blocks on a Panel page depends the user role and their previous configurated permissions, therefore which that module you can create different custom blocks selectors for user roles.

Project link

https://www.drupal.org/project/custom_panels_blocks

Git instructions

git clone --branch 8.x-4.x https://git.drupal.org/project/custom_panels_blocks.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-custom_panels_...

Comments

aperedos created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

Remember to change status, when the project is ready to be reviewed.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
aperedos’s picture

aperedos commented
Status: Active » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

Thank you for your contribution!
I am adding the PAReview checklist link. If you haven't done it yet, please check the reported issues, and fix the code as indicated. Don't pay attention to the false positives the checklist could contain.

Next, the reviewers will check the project code, and report here what needs to be changed.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

There is a 8.x-4.x tag, and a branch with the same name. The tag needs to be removed, since it's not the correct name for a tag, which should be (for example), 8.x-4.0.

Also, notice that, for the purpose of this application, it's not necessary to create tags, or have releases that aren't the development snapshot.

aperedos’s picture

aperedos commented

Hi,

The tag, has been removed, i will check the PAReview to resolve all Warnings, and i will create a new branch for testing again.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

There is no need to create new branches. Just commit the code in the existing one.
Once the tag with the same name of the branch is removed, there aren't problems anymore.

aperedos’s picture

aperedos commented

Ok, thanks, I will review the code and commit again on the current branch.

aperedos’s picture

aperedos commented

Hi @kiamlaluno

All code has been pushed on the current branch and test is passed.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
sgostanyan’s picture

sgostanyan commented
Status: Needs review » Reviewed & tested by the community

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.

No duplication
[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch
[Yes: Follows] the guidelines for master branch.

Licensing
[Yes: Follows] the licensing requirements.

3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md
[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review
[Yes: Follows] the guidelines for project length and complexity.

Secure code
[Yes: Meets the security requirements.]

Coding style & Drupal API usage

  • Use of a depreciated function "Drupal:url()", it should be replaced by "Url::fromRoute()" instead
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.