Update to follow Drupal coding standards.

CommentFileSizeAuthor
#4 webform-rest-3019816-4.patch2.81 KBorlando.thoeny
#2 webform-rest-3019816-2.patch4.73 KBsilvi.addweb

Comments

imclean created an issue. See original summary.

silvi.addweb’s picture

silvi.addweb commented
Status: Active » Needs review
StatusFileSize
new webform-rest-3019816-2.patch4.73 KB

@imclean, Please find my attached patch that resolves the coding standard issues, as per the pareview.sh report. thanks!.

imclean’s picture

imclean commented
Assigned: imclean » Unassigned
Status: Needs review » Needs work

Thanks, I hadn't got around to it yet. Is this the only file with problems?

+++ b/src/Plugin/rest/resource/WebformFieldsResource.php
@@ -45,7 +45,7 @@ class WebformFieldsResource extends ResourceBase {
+      // $form = $webform->getSubmissionForm();

This can be removed completely.

orlando.thoeny’s picture

orlando.thoeny
Location Switzerland 🇨🇭
commented
Status: Needs work » Needs review
StatusFileSize
new webform-rest-3019816-4.patch2.81 KB

Created a new patch that removed the mentioned line.

  • dgaspara committed 795d814 on 4.x 
    Issue #3019816 by dev16.addweb, orlando.thoeny, dgaspara: Coding...

  • dgaspara committed 8fd10ed on 8.x-2.x 
    Issue #3019816 by dev16.addweb, orlando.thoeny: Coding standards -...
dgaspara’s picture

dgaspara commented
Status: Needs review » Fixed

Hi, the patch looks good. I tested manually and it work as expected. Thank you for your contribution.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.