Hi,

As many admin don't want views_ui enabled on production server, this module should not depend on it.

Hope this helps.

CommentFileSizeAuthor
#2 Update_dependencies_format_in_info.yml_019621-2.patch303 byteschipway

Comments

chipway created an issue. See original summary.

chipway’s picture

chipway commented
Assigned: chipway » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Update_dependencies_format_in_info.yml_019621-2.patch303 bytes

Here is the patch. Please review.

sagarwani’s picture

sagarwani commented

Hi @chipway

thanks for your help in this module, i tried this patch, every thing is ok but just one thing if we disable views ui module and still keep views custom table module then we do not get any direct link for the configuration page, we still can navigate to it from module list page, but still i don't think that it is a good idea to remove it's dependency. lets wait if other developers also rise same issue so i will think about it, until that people who want to takeout dependency of views ui they can refer to this issue and take out views ui dependency

chipway’s picture

chipway commented

Thanks Sagar for taking this into account.

In fact, on many production site, we don't want to be able to configure modules. This should be done on a dev/test/pre-prod environment then configuration is deployed.
This enhances security of the website.
When you don't have dependency on view_ui, administrators still may enable view_ui if they like. So everyone is happy.
Have a good day.

  • sagarwani committed e419b99 on 8.x-1.x authored by chipway 
    Issue #3019621 by chipway, sagarwani: Should not depend on views_ui
sagarwani’s picture

sagarwani commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.