I found your template and like the sleek and straight version.

I'm not a Themer. I have build the Size with Drupal 8.84 and for now with bartik as a design.

Now I would like to use theone for a more modern design.

But now I have following problems.

The Title does not show as expected - see picture title

There is a links : more about us - but I don't find where to influence it.

see picture : moreaboutus.png

the main image does not resize, although I used the same size as back2.jpg

see Image 1 and Image 2

on a mobile phone it get's all squeezed from both sides.

I will be able to get you access on a test site.

would you be able to give support ??

thank you Lothar

CommentFileSizeAuthor
#11 final2.0-3019359-11.patch1.9 KBsuraj098
#9 final-3019359-9.patch1.84 KBsuraj098
#6 title-3019359-6.patch279 bytessuraj098
#5 moreaboutus-bckgrndResp-3019359-5.patch1.62 KBsuraj098
#2 after-patch2.png47.96 KBsuraj098
#2 after-patch1.png350.96 KBsuraj098
#2 footlink-backgroundresp-3019359-2.patch2.19 KBsuraj098
Image 2.png1.85 MBlomale@bluewin.ch
Image 1.png3.99 MBlomale@bluewin.ch
moreaboutus.png46.16 KBlomale@bluewin.ch
Title.png335.14 KBlomale@bluewin.ch

Comments

lomale created an issue. See original summary.

suraj098’s picture

suraj098 commented
Component: Miscellaneous » Code
Assigned: Unassigned » suraj098
Status: Active » Needs review
StatusFileSize
new footlink-backgroundresp-3019359-2.patch2.19 KB
new after-patch1.png350.96 KB
new after-patch2.png47.96 KB

Hi Lothar,

I've addressed the issues you've mentioned here on my patch. Please verify.
You can add a link to the 'moreboutus' by adding the link to the 'a' tag as ' href="yourlink.com" ' in the page.html.twig and page--front.html.twig.
However i could not recreate the issue you've presented with the Title.png. Please provide a little more detail on where this issue has occurred.

gaurav.kapoor’s picture

gaurav.kapoor commented

The patch doesn't apply after recent commits. Please provide a new patch.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Needs work
suraj098’s picture

suraj098 commented
Status: Needs work » Needs review
StatusFileSize
new moreaboutus-bckgrndResp-3019359-5.patch1.62 KB

I've provided a new patch. Please verify.

Thank You.

suraj098’s picture

suraj098 commented
StatusFileSize
new title-3019359-6.patch279 bytes

I was able to recreate the title issue that was mentioned prior to the patch provided.
Here is another patch to fix the title issue.

Premanshu’s picture

Premanshu commented
Status: Needs review » Needs work
Issue tags: +Novice

The Patch number 5 does not apply cleanly. This may be due to recent commits. Please provide a new patch.

Also, I see that in your patch you have changed "More about us" text from a paragraph element to a link. This will cause the text style for the "More about us" text to deviate from the design. Please handle the text styles for this link and match it to the design.

suraj098’s picture

suraj098 commented
suraj098’s picture

suraj098 commented
Status: Needs work » Needs review
StatusFileSize
new final-3019359-9.patch1.84 KB

Okay. Please review this new patch. It has all the previous patches as well.

meenakshig’s picture

meenakshig commented
Status: Needs review » Needs work

Static strings should be translatable.
Adding reference for the solution
https://stackoverflow.com/questions/44325712/drupal-8-translate-string-f...

suraj098’s picture

suraj098 commented
StatusFileSize
new final2.0-3019359-11.patch1.9 KB

Thank you for the reference. I hope this patch resolves all the issues. Please review.

Thank you

suraj098’s picture

suraj098 commented
Status: Needs work » Needs review
suraj098’s picture

suraj098 commented
suraj098’s picture

suraj098 commented
suraj098’s picture

suraj098 commented

Please review the patch #11.

meenakshig’s picture

meenakshig commented
Status: Needs review » Reviewed & tested by the community

@suraj098 , Patch looks fine now.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.