> The Drupal\commerce\BundlePluginInterface is deprecated. Instead, use \Drupal\entity\BundlePlugin\BundlePluginInterface

CommentFileSizeAuthor
#17 commerce-license-3018780-16.patch1.19 KBsahana _n
#15 commerce-license-3018780-15-D8.patch1.19 KBkaran sen
#10 commerce-license-3018780-10-D8.patch1.13 KBkaran sen
#6 commerce-license-3018780-6.patch1.91 KBsershevchyk
#2 3018780-1.patch1.13 KBhardikpandya

Comments

joachim created an issue. See original summary.

hardikpandya’s picture

hardikpandya commented
Status: Active » Needs review
StatusFileSize
new 3018780-1.patch1.13 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3018780-1.patch, failed testing. View results

nginex’s picture

nginex commented
Issue tags: +LutskGCW19
sershevchyk’s picture

sershevchyk
Primary language Ukrainian
Location Lutsk
commented
Assigned: Unassigned » sershevchyk
sershevchyk’s picture

sershevchyk
Primary language Ukrainian
Location Lutsk
commented
StatusFileSize
new commerce-license-3018780-6.patch1.91 KB

Added method calculateStart to fix the latest test error:

PHP Fatal error: Class Drupal\commerce_license_set_expiry_test\Plugin\RecurringPeriod\CommerceLicenseSetExpiryTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Drupal\recurring_period\Plugin\RecurringPeriod\RecurringPeriodInterface::calculateStart) in /var/www/html/modules/contrib/commerce_license/tests/modules/commerce_license_set_expiry_test/src/Plugin/RecurringPeriod/CommerceLicenseSetExpiryTest.php on line 14

sershevchyk’s picture

sershevchyk
Primary language Ukrainian
Location Lutsk
commented
Assigned: sershevchyk » Unassigned
joachim’s picture

joachim commented

> PHP Fatal error: Class Drupal\commerce_license_set_expiry_test\Plugin\RecurringPeriod\CommerceLicenseSetExpiryTest contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Drupal\recurring_period\Plugin\RecurringPeriod\RecurringPeriodInterface::calculateStart)

That's an unrelated problem, that we shouldn't fix here.

It's entirely my fault too -- I thought I'd made the recent additions to recurring_period backwards-compatible, and apparently I've messed it up.

joachim’s picture

joachim commented

The recurring_period issue should be fixed now.

karan sen’s picture

karan sen commented
StatusFileSize
new commerce-license-3018780-10-D8.patch1.13 KB

Used \Drupal\entity\BundlePlugin\BundlePluginInterface, here's the patch.

karan sen’s picture

karan sen commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: commerce-license-3018780-10-D8.patch, failed testing. View results

joachim’s picture

joachim commented 
+++ b/src/Plugin/Commerce/LicenseType/LicenseTypeSynchronizableInterface.php
@@ -2,7 +2,6 @@
-use Drupal\commerce\BundlePluginInterface;

You have to replace this removal too!

karan sen’s picture

karan sen commented

Hi @joachim, This is unsued used statement here, that is why removed it.

karan sen’s picture

karan sen commented
Status: Needs work » Needs review
StatusFileSize
new commerce-license-3018780-15-D8.patch1.19 KB

@joachim replaced both the use statement in both the places. Please have a look.

Status: Needs review » Needs work

The last submitted patch, 15: commerce-license-3018780-15-D8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

sahana _n’s picture

sahana _n commented
Status: Needs work » Needs review
StatusFileSize
new commerce-license-3018780-16.patch1.19 KB

replaced Drupal\commerce\BundlePluginInterface with \Drupal\entity\BundlePlugin\BundlePluginInterface

Status: Needs review » Needs work

The last submitted patch, 17: commerce-license-3018780-16.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

joachim’s picture

joachim commented

There's no need to keep uploading the same or similar patches. The tests are failing because of another problem, that needs to be fixed in a separate issue.

quiron’s picture

quiron
Primary language Catalan
Location Barcelona
commented
Status: Needs work » Reviewed & tested by the community
Related issues: +#3032710: Tests broken for 8.x-2.x

I fixed the tests issue in the patch in #3032710

Tested both patches and the tests work fine, so I guess this is RTBC

jsacksick’s picture

jsacksick commented
Status: Reviewed & tested by the community » Closed (duplicate)

This was fixed in dev already.