According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#4 vrbg-3018393-4.patch894 bytesSnehal Brahmbhatt
#2 views_role_based_global_text-info-3018393-2.patch377 bytesalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new views_role_based_global_text-info-3018393-2.patch377 bytes

I uploaded a patch that fixs dependency namespacing in the .info.yml file.
Thanks!

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs review » Needs work

Patch looks fine to me.

However, when I just checked in PARReview.sh, I found few other coding standards issue.

https://pareview.sh/pareview/https-git.drupal.org-project-views_role_bas...

FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/src/RoleBasedGlobalText.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
  3 | ERROR | [x] Namespaced classes, interfaces and traits should not
    |       |     begin with a file doc comment
  5 | ERROR | [x] Doc comment short description must end with a full stop
 13 | ERROR | [x] Missing class doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...rupal/pareviewsh/pareview_temp/views_role_based_global_text.info.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

I think patch should also incoporate these.

Thanks!

Snehal Brahmbhatt’s picture

Snehal Brahmbhatt commented
Status: Needs work » Needs review
StatusFileSize
new vrbg-3018393-4.patch894 bytes

@alonaoneill @joshi.rohit100, Please find my below patch, that resolves some Coding Standard errors:

1) Remove comment before the namespace

2) Added class comment

3) Set drupal dependancy and remove extra line

Hope this helps you..

Thanks!.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs review » Fixed

Merged! Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.