Trying to execute a rule with this action fails with message: "The website encountered an unexpected error. Please try again later." Checking the logs shows it is trying to do a sql query with an invalid column `path` (see image).

CommentFileSizeAuthor
#6 3018343-6-path-actions-and-conditions.patch16.4 KBtr
#4 3018343-4-path-actions-and-conditions.patch14.52 KBtr
#3 3018343-3-path-actions-and-conditions.patch12.41 KBtr
Untitled.png59.13 KBkwfinken

Comments

kwfinken created an issue. See original summary.

tr’s picture

tr commented
Assigned: Unassigned » tr
Priority: Major » Normal

Sigh, it looks like it NEVER worked, and the tests for that action are buggy so they never detected that. I really don't know how that feature got committed without someone trying it manually in the UI ...

Looks like pretty much all path alias conditions and actions have a problem. I've got this fixed locally now and will be posting a patch in the next day or so - I want to add new tests and fix a lot of wrong comments in the path alias code.

tr’s picture

tr commented
Status: Active » Needs review
StatusFileSize
new 3018343-3-path-actions-and-conditions.patch12.41 KB

I forgot to post the patch for this. I'm not sure it's complete.

This could use some manual testing! Use these conditions/actions in your Rules, try them out, and let us know how they work!

tr’s picture

tr commented
StatusFileSize
new 3018343-4-path-actions-and-conditions.patch14.52 KB

Missed a few. New patch attached.

Status: Needs review » Needs work

The last submitted patch, 4: 3018343-4-path-actions-and-conditions.patch, failed testing. View results

tr’s picture

tr commented
Status: Needs work » Needs review
StatusFileSize
new 3018343-6-path-actions-and-conditions.patch16.4 KB

  • TR committed 204bb5c on 8.x-3.x 
    Issue #3018343 by TR: "Delete all aliases for a path" action fails
tr’s picture

tr commented
Status: Needs review » Fixed

Since no one has been testing any of the patches in this queue, the only hope of getting this reviewed is to commit the patch and get these changes into the next release. If there are any remaining issues they should be found when people start using the code.

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.