Closed (fixed)
Project:
Commerce USPS
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Dec 2018 at 03:56 UTC
Updated:
5 Apr 2019 at 17:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
shabana.navas commentedInitial cleaned up version. Looking for review and hoping to get some answers to the following questions so that we can further clean this up:
In the work done here: https://github.com/mattwebdev/commerce_usps the USPS services are not explicitly listed.
Comment #3
andyg5000Hey shabana.navas,
I started https://github.com/blueoakinteractive/commerce_usps/tree/8.x-3.x as a fork of Matt's stuff to get it ready for D.O a while back and guess I never worked to move it over here. Not saying we should keep it, but it might have some things we can keep. I do agree that we should follow what UPS is doing regarding defined services and match the patterns so there similar to maintain.
Comment #4
shabana.navas commentedThanks andyg5000, I'll take a look at the repo and try and merge the two. As for the services, yeah, it's better to define them like UPS is doing. There are quite a few USPS services that are available, do we have a preference for which ones we should offer?
Comment #5
shabana.navas commentedComment #6
shabana.navas commented@andyg5000 I've gone through the repo and we've got most of the stuff in the patch here. It just adds on to those changes.
The major difference is we don't have the UPSTrack class in this patch. But the class mostly contains test code so I left it out until we fully build out the feature.
The new patch attached here adds the services explicitly and removes the exclude options.
Comment #7
shabana.navas commentedComment #8
shabana.navas commentedComment #9
cameron prince commentedSo how do https://github.com/trobey/commerce_usps and https://github.com/blueoakinteractive/commerce_usps compare?
I have been testing with the trobey version and it seems to work well. I have found a bug related to having a donation in an order along with a product shipped via USPS. I came here to check for patches and found this.
It sure would be nice to consolidate our efforts.
Comment #10
andyg5000We should continue to push forward with what @shabana.navas has done above. I apologize that more hasn't been done on the 8.x version of this, I just haven't had the need for it. I didn't know there was yet another fork/version with Trobey's version. If there is useful stuff in his version, we should work to add it to #6.
Comment #11
andyg5000Hey @shabana.navas
Good news... I rolled 8.x-1.x and committed your patch. The only thing that I did not include were the package definitions. I wasn't sure why you put those in config/install instead of using the shipping API and having them in the root. Let me know your thoughts there an we'll get them included. I was also not sure why there were separate files for each.
Comment #12
andyg5000Comment #13
jonnyeom commentedJust want to say that I am currently running the latest version of commerce_usps 8.x-1.x and everything is working great in our environments.
Thanks for the great work!
Also, extra thanks for implementing the V2 International API!
Jonathan
Comment #14
andyg5000w00t. Great to hear, thanks for the feedback!
Comment #15
smccabe commentedComment #16
shabana.navas commented@andyg5000 Thanks for committing the patch and thanks guys for testing this out. You're right, I have no idea why I added the package types in their own files and put it under config/install. The attached patch keeps it the same and adds the weight attribute to the package types.
Comment #17
andyg5000Hey @shabana.navas,
What does the weight attribute on these do? For example, what significance does 3lbs have on usps_medium_flat_rate_box?
If you got this from USPS, can you include a link to the reference?
Thanks!
Comment #18
shabana.navas commentedSorry, that was the wrong patch.
Comment #19
shabana.navas commentedActually, on further testing, I'm getting a
Call to a member function getRemoteId()error with the default package declarations. Maybe something wonky on my local.I've left the weights off for now. The dimensions have been corrected and have been fetched from https://www.stamps.com/usps/priority-mail-flat-rate/ and https://help.shipstation.com/hc/en-us/articles/360001779252-What-package...()
Comment #20
andyg5000