According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#4 Screen Shot 2018-12-10 at 3.04.47 PM.png248.8 KBdhirendra.mishra
#2 path_corrector-info-3017833-2.patch313 bytesalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new path_corrector-info-3017833-2.patch313 bytes

I uploaded a patch that fixs dependency namespacing in the .info.yml file.
Thanks!

Status: Needs review » Needs work

The last submitted patch, 2: path_corrector-info-3017833-2.patch, failed testing. View results

dhirendra.mishra’s picture

dhirendra.mishra commented
StatusFileSize
new Screen Shot 2018-12-10 at 3.04.47 PM.png248.8 KB

As results fails due to yml parsing , would this be created another issue?

alonaoneill’s picture

alonaoneill commented
Status: Needs work » Reviewed & tested by the community

Yes, I think it should be another issue.
Thanks.
Patch is working, so marking RTBCed

nicholasthompson’s picture

nicholasthompson
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks :)
Committed in ef51591

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.