Setup:
* 2 shipping methods enabled, Fedex and USPS
* USPS working propertly
* Fedex failing (bug filed separately)

Expectation:
* USPS shipping method will still be displayed
* Fedex failure logged

Observed:
* No shipping methods displayed, user cannot proceed to checkout

CommentFileSizeAuthor
#10 3017776-10.patch4.96 KBjsacksick
#10 3017776-10-tests-only.patch1.85 KBjsacksick
#9 commerce_shipping-handle_exceptions_during_rate_calculation-3017776-9.patch3.7 KBdkosbob
#8 commerce_shipping-handle_exceptions_during_rate_calculation-3017776-8.patch3.45 KBaaronbauman
#8 commerce_shipping-handle_exceptions_during_rate_calculation-3017776-8-TEST-ONLY.patch1.86 KBaaronbauman
#4 commerce_shipping-handle_exceptions_during_rate_calculation-3017776-3.patch2.73 KBaaronbauman

Comments

aaronbauman created an issue. See original summary.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Active » Needs review

Cross-referencing PR: https://github.com/drupalcommerce/commerce_shipping/pull/10

bojanz’s picture

bojanz commented

Let's create a patch please.

aaronbauman’s picture

aaronbauman
he/him
commented
StatusFileSize
new commerce_shipping-handle_exceptions_during_rate_calculation-3017776-3.patch2.73 KB
aaronbauman’s picture

aaronbauman
he/him
commented

If this looks like the right approach, i can update the logging method + translation to DIC if that's important

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Issue tags: +Needs tests

Handling exceptions when calculating is a good call. We should add a test with a test shipping method plugin which throws an exception as well

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Needs work

Moving to NW per my last comment, we need to add a test.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new commerce_shipping-handle_exceptions_during_rate_calculation-3017776-8-TEST-ONLY.patch1.86 KB
new commerce_shipping-handle_exceptions_during_rate_calculation-3017776-8.patch3.45 KB

Finally getting around to a reroll here, with test

- "TEST-ONLY" should fail
- regular patch fixes the test

dkosbob’s picture

dkosbob commented
StatusFileSize
new commerce_shipping-handle_exceptions_during_rate_calculation-3017776-9.patch3.7 KB

Patch no longer applying, here is a reroll.

jsacksick’s picture

jsacksick commented
StatusFileSize
new 3017776-10-tests-only.patch1.85 KB
new 3017776-10.patch4.96 KB

The logic for calculating rates now lives in the ShipmentManager, so the ShipmentManagerTest needs to be updated and the exception should be caught in the ShipmentManager.

jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

_

jsacksick’s picture

jsacksick commented
Status: Fixed » Needs review
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed. Thanks, everyone.

  • bojanz committed 938ed0c on 8.x-2.x authored by AaronBauman 
    Issue #3017776 by AaronBauman, jsacksick, dkosbob, mglaman: Exception in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.