Problem/Motivation

Views UI module has no views_ui.admin.inc but \Drupal\views\Plugin\views\wizard\WizardPluginBase trying to load it
is_file() check in module_load_include() hides this error

Proposed resolution

Remove useless calls

Remaining tasks

patch

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

no

CommentFileSizeAuthor
#15 3017299-15.patch1.24 KBkishor_kolekar
#12 3017299-12.patch1.24 KBhimanshu_sindhwani
#3 3017299-3.patch3.13 KBandypost
#3 interdiff.txt1.43 KBandypost
#2 3017299-2.patch1.34 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 3017299-2.patch1.34 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Remove unused module_load_include() from WizardPluginBase » Remove unused module_load_include() in view_ui module
StatusFileSize
new interdiff.txt1.43 KB
new 3017299-3.patch3.13 KB

And the rest

The last submitted patch, 2: 3017299-2.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 3: 3017299-3.patch, failed testing. View results

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

It is loading core/modules/views_ui/admin.inc which still exists and is needed for the calls to views_ui_add_ajax_trigger().

Works as designed?

andypost’s picture

andypost
he/him
Primary language Russian
commented

Is there issue to kill this include?

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Looks now it duplicates #3035340: Deprecate core/modules/views_ui/admin.inc

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

himanshu_sindhwani’s picture

himanshu_sindhwani commented
StatusFileSize
new 3017299-12.patch1.24 KB

Removing module_load_include() from WizardPluginBase.php

anuj.sharma0103’s picture

anuj.sharma0103 commented
Status: Needs work » Needs review
daffie’s picture

daffie commented
Status: Needs review » Needs work

The testbot is failing and this needs a patch for 9.1 first.

kishor_kolekar’s picture

kishor_kolekar commented
Status: Needs work » Needs review
StatusFileSize
new 3017299-15.patch1.24 KB

address the comment #14 reroll the patch for 9.1
please review the patch.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: -#697946: Properly deprecate module_load_include() and move it into \Drupal::moduleHandler() service +#3035340: Deprecate core/modules/views_ui/admin.inc

it will not work as #6 said, I'd better closed it as duplicate of #3035340: Deprecate core/modules/views_ui/admin.inc

Status: Needs review » Needs work

The last submitted patch, 15: 3017299-15.patch, failed testing. View results

himanshu_sindhwani’s picture

himanshu_sindhwani commented
Status: Needs work » Closed (duplicate)

I agree this depends on views_ui_add_ajax_trigger() depends on module_load_include(), marking this as closed.