Problem/Motivation

In #2465887: Extract the install/uninstall functionality to a ThemeInstaller responsibility of [un]install of themes moved to theme_installer service but no CR filed and deprecated methods still used in core

Proposed resolution

Replace all usages of ThemeHandlerInterface::uninstall() and ThemeHandlerInterface::install() and trigger a silenced error.

Remaining tasks

patch, review & commit

User interface changes

None

API changes

None

Data model changes

None

Comments

andypost created an issue. See original summary.

andypost’s picture

Assigned: Unassigned » andypost

Filed CR https://www.drupal.org/node/3017233 and working on patch

andypost’s picture

Title: Properly deprecate ThemeHandlerInterface::uninstall() and remove usage » Properly deprecate ThemeHandlerInterface install() and uninstall() also replace usage
Status: Active » Needs review
StatusFileSize
new12.35 KB

Added deprecation and cleaned uninstall() usage

andypost’s picture

StatusFileSize
new61.27 KB
new73.35 KB

Replace usage of install()

The last submitted patch, 4: 3017231-4.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 5: 3017231-5.patch, failed testing. View results

andypost’s picture

Status: Needs work » Needs review
StatusFileSize
new7.29 KB
new80.63 KB

Fix few tests

Status: Needs review » Needs work

The last submitted patch, 8: 3017231-8.patch, failed testing. View results

andypost’s picture

Status: Needs work » Needs review
Related issues: +#2776031: Properly deprecate ThemeHandlerInterface install() and uninstall() also replace usage
StatusFileSize
new619 bytes
new81.24 KB

Should fix remains but means that constructor needs change so will provide BC

Meanwhile gonna mark this as duplicate of #2776031: Properly deprecate ThemeHandlerInterface install() and uninstall() also replace usage

andypost’s picture