Problem/Motivation

In #2465887: Extract the install/uninstall functionality to a ThemeInstaller responsibility of [un]install of themes moved to theme_installer service but no CR filed and deprecated methods still used in core

Proposed resolution

Replace all usages of ThemeHandlerInterface::uninstall() and ThemeHandlerInterface::install() and trigger a silenced error.

Remaining tasks

patch, review & commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#4 3017231-4.patch12.35 KBandypost
#5 interdiff.txt61.27 KBandypost
#5 3017231-5.patch73.35 KBandypost
#8 interdiff.txt7.29 KBandypost
#8 3017231-8.patch80.63 KBandypost
#10 interdiff.txt619 bytesandypost
#10 3017231-10.patch81.24 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Parent issue: #2942001: Deprecate ThemeHandlerInterface::rebuildThemeData() and use extension.list.theme service instead »
Related issues: +#2942001: Deprecate ThemeHandlerInterface::rebuildThemeData() and use extension.list.theme service instead
andypost’s picture

andypost
he/him
Primary language Russian
commented
Assigned: Unassigned » andypost

Filed CR https://www.drupal.org/node/3017233 and working on patch

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Properly deprecate ThemeHandlerInterface::uninstall() and remove usage » Properly deprecate ThemeHandlerInterface install() and uninstall() also replace usage
Status: Active » Needs review
StatusFileSize
new 3017231-4.patch12.35 KB

Added deprecation and cleaned uninstall() usage

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt61.27 KB
new 3017231-5.patch73.35 KB

Replace usage of install()

The last submitted patch, 4: 3017231-4.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 5: 3017231-5.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt7.29 KB
new 3017231-8.patch80.63 KB

Fix few tests

Status: Needs review » Needs work

The last submitted patch, 8: 3017231-8.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
Related issues: +#2776031: Properly deprecate ThemeHandlerInterface install() and uninstall() also replace usage
StatusFileSize
new interdiff.txt619 bytes
new 3017231-10.patch81.24 KB

Should fix remains but means that constructor needs change so will provide BC

Meanwhile gonna mark this as duplicate of #2776031: Properly deprecate ThemeHandlerInterface install() and uninstall() also replace usage

andypost’s picture

andypost
he/him
Primary language Russian
commented
Assigned: andypost » Unassigned
Status: Needs review » Closed (duplicate)
Issue tags: -@deprecated
Related issues: -#2942001: Deprecate ThemeHandlerInterface::rebuildThemeData() and use extension.list.theme service instead

Duplicate of #2776031: Properly deprecate ThemeHandlerInterface install() and uninstall() also replace usage